Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 74953005: Fix https://code.google.com/p/dart/issues/detail?id=15132, by not doing load elimination on typed a… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (revision 30337)
+++ sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (working copy)
@@ -1832,6 +1832,13 @@
&& mask.satisfies(jsIndexingBehaviorInterface, compiler);
}
+ bool couldBeTypedArray(TypeMask mask) {
+ TypeMask indexing = new TypeMask.subtype(jsIndexingBehaviorInterface);
+ // Checking if [mask] contains [indexing] means that we want to
+ // know if [mask] is not a more specific type than [indexing].
+ return isTypedArray(mask) || mask.containsMask(indexing, compiler);
+ }
+
/// Called when [enqueuer] is empty, but before it is closed.
void onQueueEmpty(Enqueuer enqueuer) {
if (!enqueuer.isResolutionQueue && preMirrorsMethodCount == 0) {
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698