Issue 749523002: Move inspector_backend_mojo.cc to v8_inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 749523002: Move inspector_backend_mojo.cc to v8_inspector (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
yurys, abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move inspector_backend_mojo.cc to v8_inspector Also fixed several chromium style errors in the file. I had to make web depend on v8_inspector for the time being until v8_inspector can be weened off of the Page class. R=abarth@chromium.org, yurys@chromium.org BUG=435243 Committed: https://chromium.googlesource.com/external/mojo/+/9b7e774660abc5a46f42b5f30f279e48109941dd

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -205 lines)			Patch
M	sky/engine/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/core.gni	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/core/inspector/inspector_backend_mojo.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	sky/engine/core/inspector/inspector_backend_mojo.cc	View	1 chunk	+0 lines, -107 lines	0 comments	Download
M	sky/engine/v8_inspector/BUILD.gn	View	2 chunks	+9 lines, -3 lines	0 comments	Download
A +	sky/engine/v8_inspector/inspector_backend_mojo.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A +	sky/engine/v8_inspector/inspector_backend_mojo.cc	View	4 chunks	+31 lines, -30 lines	0 comments	Download
M	sky/engine/web/BUILD.gn	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.h	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

6 years, 1 month ago (2014-11-20 19:30:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9b7e774660abc5a46f42b5f30f279e48109941dd (presubmit successful).

Expand Messages | Collapse Messages