Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 749393005: Translate the overscroll elasticity layer by the overscroll amount (Closed)

Created:
6 years ago by ccameron
Modified:
6 years ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@aelias
Project:
chromium
Visibility:
Public.

Description

Translate the overscroll elasticity layer by the overscroll amount Add a synced property, elastic_overscroll, similar to page_scale_factor. Use this property to translate the overscroll elasticity layer. With this in place, the overscroll effect works most of the time, when using impl-thread events. Originally committed at r306991, reverted at r306995 due to ASAN break due to LTI::overscroll_elasticity_layer_ not being initialized. BUG=133097 TBR=aelias Committed: https://crrev.com/b9aec4502197bf280b1c66f7104ed78937894b22 Cr-Commit-Position: refs/heads/master@{#307057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -20 lines) Patch
M cc/input/scroll_elasticity_helper.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M cc/input/top_controls_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 4 chunks +9 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 6 chunks +12 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 4 chunks +16 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 5 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ccameron
Re-landing this with TBR -- the previous land didn't take because a previous patch hadn't ...
6 years ago (2014-12-05 18:25:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749393005/1
6 years ago (2014-12-05 18:26:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 19:31:12 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-05 19:32:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9aec4502197bf280b1c66f7104ed78937894b22
Cr-Commit-Position: refs/heads/master@{#307057}

Powered by Google App Engine
This is Rietveld 408576698