- Implement Isolate.ping.

runtime/vm/message.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/message.h"
 
 #include "vm/port.h"
 
 namespace dart {
 
@@ skipping 13 matching lines @@
 }
 
 
 MessageQueue::~MessageQueue() {
   // Ensure that all pending messages have been released.
   Clear();
   ASSERT(head_ == NULL);
 }
 
 
-void MessageQueue::Enqueue(Message* msg) {
+void MessageQueue::Enqueue(Message* msg, bool before_events) {
   // Make sure messages are not reused.
   ASSERT(msg->next_ == NULL);
-  if (head_ == NULL) {
-    // Only element in the queue.
-    ASSERT(tail_ == NULL);
-    head_ = msg;
-    tail_ = msg;
+  if (!before_events) {
+    if (head_ == NULL) {
+      // Only element in the queue.
+      ASSERT(tail_ == NULL);
+      head_ = msg;
+      tail_ = msg;
+    } else {
+      ASSERT(tail_ != NULL);
+      // Append at the tail.
+      tail_->next_ = msg;
+      tail_ = msg;
+    }
   } else {
-    ASSERT(tail_ != NULL);
-    // Append at the tail.
-    tail_->next_ = msg;
-    tail_ = msg;
+    ASSERT(msg->dest_port() == Message::kIllegalPort);
+    if (tail_ == NULL) {
+      ASSERT(head_ == NULL);
+      head_ = msg;
+      tail_ = msg;

[siva, 2014/12/01 19:48:05]

The "only element in queue" case is common always why not hoist that out to make
the code simpler to read:

if (head_ == NULL) {
  // Only element in the queue.
  ASSERT(tail_ == NULL);
  head_= msg;
  tail_ = msg;
} else {
  if (!before_events) {
    ASSERT(tail_ != NULL);
    // Append at the tail.
    ...
    ...
  } else {
    ASSERT(head_ != NULL);
    if (head->dest_port() != Message::kIllegalPort) {
      ...
      ...
    } else {
      Message* cur = head_;
      ...
      ...
    }
  }
}

[Ivan Posva, 2014/12/12 20:21:46]

Done.

+    } else if (head_->dest_port() != Message::kIllegalPort) {
+      msg->next_ = head_;
+      head_ = msg;
+    } else {
+      ASSERT(head_ != NULL);  // Is guaranteed by "if (tail_ == NULL)" above.
+      Message* cur = head_;
+      while (cur->next_ != NULL) {
+        if (cur->next_->dest_port() != Message::kIllegalPort) {
+          // Splice in the new message at the break.
+          msg->next_ = cur->next_;
+          cur->next_ = msg;
+          return;
+        }
+        cur = cur->next_;
+      }
+      // All pending messages are isolate library control messages. Append at
+      // the tail.
+      ASSERT(tail_ == cur);
+      ASSERT(tail_->dest_port() == Message::kIllegalPort);
+      tail_->next_ = msg;
+      tail_ = msg;
+    }
   }
 }
 
 
 Message* MessageQueue::Dequeue() {
   Message* result = head_;
   if (result != NULL) {
     head_ = result->next_;
     // The following update to tail_ is not strictly needed.
     if (head_ == NULL) {
@@ skipping 18 matching lines @@
       PortMap::PostMessage(cur);
     } else {
       delete cur;
     }
     cur = next;
   }
 }
 
 
 }  // namespace dart