Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8680)

Unified Diff: chrome/test/chromedriver/embed_mobile_devices_in_cpp.py

Issue 749353003: [chromedriver] Fix mobile device embedding script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/embed_mobile_devices_in_cpp.py
diff --git a/chrome/test/chromedriver/embed_mobile_devices_in_cpp.py b/chrome/test/chromedriver/embed_mobile_devices_in_cpp.py
index 2667014c95a5b775bfbf6a6de30163e5f7c0fef5..45e37cd0a4cf1d87940132f26265d7d295a16efa 100755
--- a/chrome/test/chromedriver/embed_mobile_devices_in_cpp.py
+++ b/chrome/test/chromedriver/embed_mobile_devices_in_cpp.py
@@ -12,11 +12,24 @@ will be written to a C-style string to be parsed with JSONReader.
import optparse
import os
+import re
import sys
import cpp_source
+def quotizeKeys(s, keys):
+ """Returns the string s with each instance of each key wrapped in quotes.
+
+ Args:
+ s: a string containing keys that need to be wrapped in quotes.
+ keys: an iterable of keys to be wrapped in quotes in the string.
+ """
+ for key in keys:
+ s = re.sub('%s: ' % key, '"%s": ' % key, s)
+ return s
+
+
def main():
parser = optparse.OptionParser()
parser.add_option(
@@ -30,8 +43,10 @@ def main():
with open(file_name, 'r') as f:
for line in f:
if not inside_list:
- if 'WebInspector.OverridesUI._phones = [' in line or \
- 'WebInspector.OverridesUI._tablets = [' in line:
+ if 'WebInspector.OverridesUI._phones = [' in line:
+ inside_list = True
+ if 'WebInspector.OverridesUI._tablets = [' in line:
+ devices += ','
inside_list = True
else:
if line.strip() == '];':
@@ -40,6 +55,9 @@ def main():
devices += line.strip()
devices += ']'
+ devices = quotizeKeys(devices,
+ ['title', 'width', 'height', 'deviceScaleFactor',
+ 'userAgent', 'touch', 'mobile'])
cpp_source.WriteSource('mobile_device_list',
'chrome/test/chromedriver/chrome',
options.directory, {'kMobileDevices': devices})
« chrome/test/chromedriver/cpp_source.py ('K') | « chrome/test/chromedriver/cpp_source.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698