Plumbing for frame-specific WebWidgets

Source/core/page/ChromeClient.h

Index: Source/core/page/ChromeClient.h
diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h
index c96c24d51fbcf0d38de9e643b7e15618a2da9b3e..015a418034abf86ba7a6e79c4ff4d87e28ba0e10 100644
--- a/Source/core/page/ChromeClient.h
+++ b/Source/core/page/ChromeClient.h
@@ -141,6 +141,8 @@ public:
     virtual void scheduleAnimation() = 0;
     // End methods used by HostWindow.
 
+    virtual void scheduleAnimationForFrame(LocalFrame* rootFrame) { }

[dcheng, 2014/11/25 20:05:13]

Ditto for naming consistency, here and elsewhere.

[kenrb, 2014/11/26 16:17:11]

Removed the name here.

+
     virtual void dispatchViewportPropertiesDidChange(const ViewportDescription&) const { }
 
     virtual void contentsSizeChanged(LocalFrame*, const IntSize&) const = 0;
@@ -177,8 +179,10 @@ public:
     // Allows ports to customize the type of graphics layers created by this page.
     virtual GraphicsLayerFactory* graphicsLayerFactory() const { return nullptr; }
 
-    // Pass 0 as the GraphicsLayer to detatch the root layer.
-    virtual void attachRootGraphicsLayer(GraphicsLayer*) = 0;
+    // Pass 0 as the GraphicsLayer to detach the root layer.
+    // This sets the graphics layer for the LocalFrame's WebWidget, if it has one. Otherwise
+    // it sets it for the WebViewImpl.
+    virtual void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame*) = 0;

[dcheng, 2014/11/25 20:05:13]

LocalFrame here should be a local root as well, right?

[kenrb, 2014/11/26 16:17:11]

I think the comment is sufficient. The important thing is that the frame has a
WebWidget.

[dcheng, 2014/11/26 16:27:13]

I think it's actually important to say "localRoot" or "localFrameRoot" here
(whatever we decide our terminology is going to be). If I just saw LocalFrame*
in the signature, it would seem reasonable (but incorrect) to assume I can pass
any LocalFrame. If you have to explain when LocalFrame has a WebWidget, you may
as well just put it directly in the name.

Unrelated: We should probably make isLocalRoot and
localFrameRoot()/localFrameRootTemporary() consistently named as well.
Personally, I think it's fine to just call it localRoot; since it always appears
with the type LocalFrame*, "frame" in the name is redundant.

[kenrb, 2014/11/26 17:31:16]

That is reasonable, but could be done as an independent rename CL.

 
     virtual void enterFullScreenForElement(Element*) { }
     virtual void exitFullScreenForElement(Element*) { }