Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 749283006: Revert of Updated the omnibox on Android to color URLs correctly (Closed)

Created:
6 years ago by jbudorick
Modified:
6 years ago
Reviewers:
Ted C, sashab
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@url_coloring_unittests
Project:
chromium
Visibility:
Public.

Description

Revert of Updated the omnibox on Android to color URLs correctly (patchset #2 id:20001 of https://codereview.chromium.org/771903003/) Reason for revert: (silently) broke org.chromium.chrome.browser.omnibox.OmniboxUrlEmphasizerTest#testShortSecureHTTPSUrlWithLightColors Original issue's description: > Updated the omnibox on Android to color URLs correctly > > Updated the URL coloring logic on Android to color the light-grey > portions of URLs (currently #969696 100% opacity) to #333333 50% opacity > on light backgrounds and #ffffff 50% opacity on dark backgrounds. Also > updated the URL coloring tests to reflect this. > > Based on crrev.com/751423003. > > BUG=430771 > > Committed: https://crrev.com/0ecb56c7474db0b57c50102adc0ee3815a0182f3 > Cr-Commit-Position: refs/heads/master@{#306558} TBR=tedchoc@chromium.org,sashab@chromium.org NOTREECHECKS=true NOTRY=true BUG=430771 Committed: https://crrev.com/2f0aedb358a0c0ebb56e451944430a1b01d18fb3 Cr-Commit-Position: refs/heads/master@{#306647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -44 lines) Patch
M chrome/android/java/res/values/colors.xml View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java View 5 chunks +9 lines, -25 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java View 8 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of Updated the omnibox on Android to color URLs correctly
6 years ago (2014-12-03 19:30:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749283006/1
6 years ago (2014-12-03 19:31:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 19:33:19 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-03 19:35:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f0aedb358a0c0ebb56e451944430a1b01d18fb3
Cr-Commit-Position: refs/heads/master@{#306647}

Powered by Google App Engine
This is Rietveld 408576698