Chromium Code Reviews
DescriptionRevert of Updated the omnibox on Android to color URLs correctly (patchset #2 id:20001 of https://codereview.chromium.org/771903003/)
Reason for revert:
(silently) broke org.chromium.chrome.browser.omnibox.OmniboxUrlEmphasizerTest#testShortSecureHTTPSUrlWithLightColors
Original issue's description:
> Updated the omnibox on Android to color URLs correctly
>
> Updated the URL coloring logic on Android to color the light-grey
> portions of URLs (currently #969696 100% opacity) to #333333 50% opacity
> on light backgrounds and #ffffff 50% opacity on dark backgrounds. Also
> updated the URL coloring tests to reflect this.
>
> Based on crrev.com/751423003.
>
> BUG=430771
>
> Committed: https://crrev.com/0ecb56c7474db0b57c50102adc0ee3815a0182f3
> Cr-Commit-Position: refs/heads/master@{#306558}
TBR=tedchoc@chromium.org,sashab@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=430771
Committed: https://crrev.com/2f0aedb358a0c0ebb56e451944430a1b01d18fb3
Cr-Commit-Position: refs/heads/master@{#306647}
Patch Set 1 #
Created: 6 years ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|
|||||||||||||||||||||||||||||||||||||