Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 749233002: [turbofan] Combine Word32And with Int32Add and negative power of two. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Combine Word32And with Int32Add and negative power of two. TEST=unittests R=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/94f5b78b96cbfc3dac55364c2672b2de213b493d

Patch Set 1 #

Patch Set 2 : Unit test #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M src/compiler/machine-operator-reducer.cc View 1 chunk +13 lines, -0 lines 4 comments Download
M src/compiler/node-matchers.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years ago (2014-11-24 12:07:56 UTC) #2
Jarin
lgtm https://codereview.chromium.org/749233002/diff/20001/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/749233002/diff/20001/src/compiler/machine-operator-reducer.cc#newcode145 src/compiler/machine-operator-reducer.cc:145: // (x + K) & K => (x ...
6 years ago (2014-11-24 12:28:09 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/749233002/diff/20001/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/749233002/diff/20001/src/compiler/machine-operator-reducer.cc#newcode145 src/compiler/machine-operator-reducer.cc:145: // (x + K) & K => (x & ...
6 years ago (2014-11-24 12:29:33 UTC) #4
Benedikt Meurer
6 years ago (2014-11-24 12:30:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
94f5b78b96cbfc3dac55364c2672b2de213b493d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698