Issue 749213003: Include whether Notification permission was requested with a user gesture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 749213003: Include whether Notification permission was requested with a user gesture. (Closed)

Created:
6 years ago by Peter Beverloo

Modified:
6 years ago

Reviewers:
Mike West

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Include whether Notification permission was requested with a user gesture. This will be used by the bubble permission request UI, and is an outstanding TODO in the code. BUG=

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -7 lines)			Patch
M	content/browser/frame_host/render_frame_host_impl.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/common/platform_notification_messages.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/renderer/notification_permission_dispatcher.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mike West

LGTM. It'd be a good idea to talk with Jochen at some point about the ...

6 years ago (2014-11-24 14:38:33 UTC) #3

Peter Beverloo

6 years ago (2014-11-24 18:38:05 UTC) #4

On 2014/11/24 14:38:33, Mike West wrote:
> LGTM. It'd be a good idea to talk with Jochen at some point about the right
> time/place to consume the user gesture, but I don't think that needs to block
> this CL.

.. and then Mounir comes by and replaces this entire code-path with way more
awesome Mojo stuff. Abandoning :-).

https://codereview.chromium.org/758603002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages