Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9934)

Unified Diff: chrome/installer/setup/install_worker_unittest.cc

Issue 749133003: Add fixing of MSI DisplayVersion to Chrome installs/updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Dear Greg Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/install_worker_unittest.cc
diff --git a/chrome/installer/setup/install_worker_unittest.cc b/chrome/installer/setup/install_worker_unittest.cc
index 29260b25e029ad6bb225bd240602c98e00ae3c2f..9d94be399636ccf635b79e485afd83d42d8ee258 100644
--- a/chrome/installer/setup/install_worker_unittest.cc
+++ b/chrome/installer/setup/install_worker_unittest.cc
@@ -672,6 +672,36 @@ TEST_F(InstallWorkerTest, AddUsageStatsWorkItems) {
&work_item_list);
}
+TEST_F(InstallWorkerTest, ConvertGUIDToMSIUserDataFormatTest) {
+ base::string16 converted_empty_guid(
+ installer::ConvertGUIDToMSIUserDataFormat(L""));
+ EXPECT_TRUE(converted_empty_guid.empty());
+
+ base::string16 malformed_guid(
+ installer::ConvertGUIDToMSIUserDataFormat(L"Marmite!"));
+ EXPECT_TRUE(malformed_guid.empty());
+
+ base::string16 short_guid(
+ installer::ConvertGUIDToMSIUserDataFormat(
+ L"Marmite!-Marm-Mite-Marm-Mite"));
+ EXPECT_TRUE(short_guid.empty());
+
+ base::string16 long_guid(
+ installer::ConvertGUIDToMSIUserDataFormat(
+ L"Marmite!-Marm-Mite-Marm-MiteMarmiteMarmiteMarmite"));
+ EXPECT_TRUE(long_guid.empty());
+
+ base::string16 off_by_one_guid(
+ installer::ConvertGUIDToMSIUserDataFormat(
+ L"Marmite!!-Marm-Mite-Marm-MiteMarmite"));
+ EXPECT_TRUE(long_guid.empty());
+
+ base::string16 correct_guid(
+ installer::ConvertGUIDToMSIUserDataFormat(
+ L"BED0D2F3-7407-3B43-A48F-6C33BC3D5DAD"));
+ EXPECT_EQ(L"3F2D0DEB704734B34AF8C633CBD3D5DA", correct_guid);
+}
+
// The Quick Enable tests only make sense for the Google Chrome build as it
// interacts with registry values that are specific to Google Update.
#if defined(GOOGLE_CHROME_BUILD)

Powered by Google App Engine
This is Rietveld 408576698