Fix grabbing capture when the mouse is pressed on Desktop Linux.

ui/views/widget/desktop_aura/x11_pointer_grab.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
+#include "ui/base/x/x11_util.h"
+#include "ui/events/devices/x11/device_data_manager_x11.h"
 #include "ui/views/widget/desktop_aura/x11_pointer_grab.h"
 
+#include <X11/extensions/XInput2.h>
 #include <X11/Xlib.h>
 
 namespace views {
 
 namespace {
 
 // The grab window. None if there are no active pointer grabs.
 XID g_grab_window = None;
 
 // The "owner events" parameter used to grab the pointer.
 bool g_owner_events = false;
 
 }  // namespace
 
 int GrabPointer(XID window, bool owner_events, ::Cursor cursor) {
-  int event_mask = PointerMotionMask | ButtonReleaseMask | ButtonPressMask;
-  int result = XGrabPointer(gfx::GetXDisplay(), window, owner_events,
-                            event_mask, GrabModeAsync, GrabModeAsync, None,
-                            cursor, CurrentTime);
+  int result = GrabInvalidTime;
+  if (ui::IsXInput2Available()) {
+    // Do an XINPUT2 pointer grab. If there is an active XINPUT2 pointer grab
+    // as a result of normal button press, XGrabPointer() will fail.
+    const std::vector<int>& master_pointers =
+        ui::DeviceDataManagerX11::GetInstance()->master_pointers();
+    for (auto master_pointer : master_pointers) {

[sadrul, 2015/02/03 01:22:49]

int

[pkotwicz, 2015/02/03 15:51:59]

Done.

+      unsigned char mask[XIMaskLen(XI_LASTEVENT)];
+      memset(mask, 0, sizeof(mask));
+      XISetMask(mask, XI_ButtonPress);
+      XISetMask(mask, XI_ButtonRelease);
+      XISetMask(mask, XI_Motion);
+      XIEventMask evmask;
+      evmask.deviceid = master_pointer;
+      evmask.mask_len = sizeof(mask);
+      evmask.mask = mask;

[sadrul, 2015/02/03 01:22:48]

Can you move initialization of |mask|/|evmask| out of the loop, and just change
|deviceid| inside before calling XIGrabDevice()?

[pkotwicz, 2015/02/03 15:51:59]

Done.

+      result = XIGrabDevice(
+          gfx::GetXDisplay(), master_pointer, window, CurrentTime, cursor,
+          GrabModeAsync, GrabModeAsync, owner_events, &evmask);
+      // Assume that the grab will succeed on either all or none of the master
+      // pointers.
+      if (result != GrabSuccess) {
+        // Try core pointer grab.
+        break;
+      }
+    }
+  }
+
+  if (result != GrabSuccess) {
+    int event_mask = PointerMotionMask | ButtonReleaseMask | ButtonPressMask;
+    result =
+        XGrabPointer(gfx::GetXDisplay(), window, owner_events, event_mask,
+                     GrabModeAsync, GrabModeAsync, None, cursor, CurrentTime);
+  }
+
   if (result == GrabSuccess) {
     g_grab_window = window;
     g_owner_events = owner_events;
   }
   return result;
 }
 
 void ChangeActivePointerGrabCursor(::Cursor cursor) {
   DCHECK(g_grab_window != None);
   GrabPointer(g_grab_window, g_owner_events, cursor);
 }
 
 void UngrabPointer() {
   g_grab_window = None;
-  XUngrabPointer(gfx::GetXDisplay(), CurrentTime);
+  if (ui::IsXInput2Available()) {
+    const std::vector<int>& master_pointers =
+        ui::DeviceDataManagerX11::GetInstance()->master_pointers();
+    for (auto master_pointer : master_pointers)

[sadrul, 2015/02/03 01:22:49]

int

[pkotwicz, 2015/02/03 15:51:59]

Done.

+      XIUngrabDevice(gfx::GetXDisplay(), master_pointer, CurrentTime);

[sadrul, 2015/02/03 01:22:49]

What happens if GrabPointer() ended up calling XGrabPointer? Would calling
XIUgrabDevice() do the right thing in that case? Or would it be necessary to
call XUngragPointer() instead?

[pkotwicz, 2015/02/03 15:51:59]

Thanks for catching this. We need to call XUngrabPointer() regardless of whether
XI2 is available.

+  } else {
+    XUngrabPointer(gfx::GetXDisplay(), CurrentTime);
+  }
 }
 
 }  // namespace views