Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chromeos/network/onc/onc_normalizer.cc

Issue 749013003: ONC: Add IPAddressConfigType and NameServersConfigType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: A bit more clarification (hopefully) Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_normalizer.cc
diff --git a/chromeos/network/onc/onc_normalizer.cc b/chromeos/network/onc/onc_normalizer.cc
index 88796bf2fa83b69b5eb498613ff501b012f4e470..a2527c1af701e64febb05ce0188ec40c3e1a6f5c 100644
--- a/chromeos/network/onc/onc_normalizer.cc
+++ b/chromeos/network/onc/onc_normalizer.cc
@@ -173,6 +173,17 @@ void Normalizer::NormalizeNetworkConfiguration(base::DictionaryValue* network) {
RemoveEntryUnless(network,
::onc::network_config::kWiFi,
type == ::onc::network_type::kWiFi);
+
+ std::string ip_address_config_type, name_servers_config_type;
+ network->GetStringWithoutPathExpansion(
+ ::onc::network_config::kIPAddressConfigType, &ip_address_config_type);
+ network->GetStringWithoutPathExpansion(
+ ::onc::network_config::kNameServersConfigType, &name_servers_config_type);
+ RemoveEntryUnless(
+ network, ::onc::network_config::kStaticIPConfig,
+ (ip_address_config_type == ::onc::network_config::kIPConfigTypeStatic) ||
+ (name_servers_config_type ==
+ ::onc::network_config::kIPConfigTypeStatic));
pneubeck (no reviews) 2015/01/07 09:23:48 not critical so i can do that in a follow-up, but
stevenjb 2015/01/07 17:28:03 Added a TODO
}
void Normalizer::NormalizeOpenVPN(base::DictionaryValue* openvpn) {

Powered by Google App Engine
This is Rietveld 408576698