Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 748943003: There is a logical error in dmprof addr command

Created:
6 years ago by wensheng
Modified:
6 years ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

There is a logical error in dmprof addr command To detect the function address belong to which library, it should be in the mapping section in /proc/[pid]/maps. But the logical has an error in dmprof addr command. R=kouhei@chromium.org BUG=435957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/deep_memory_profiler/subcommands/addr.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
wensheng
6 years ago (2014-11-24 09:39:56 UTC) #1
kouhei (in TOK)
lgtm
6 years ago (2014-11-25 00:31:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748943003/1
6 years ago (2014-11-25 00:32:44 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/26417)
6 years ago (2014-11-25 00:39:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748943003/1
6 years ago (2014-12-08 02:46:40 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-08 02:49:58 UTC) #10
Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698