Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 748873004: Revert of bluetooth: Make device/bluetooth a shared library component. (Closed)

Created:
6 years ago by scheib
Modified:
6 years ago
CC:
chromium-reviews, keybuk, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: Make device/bluetooth a shared library component. (patchset #4 id:100001 of https://codereview.chromium.org/778443002/) Reason for revert: Chrome target is failing to load due to BluetoothApis.dll not being found on Win7. Likely the DelayLoadDLLs for BluetoothApis.dll is necessary on more than just device_bluetooth. Original issue's description: > bluetooth: Make device/bluetooth a shared library component. > > device/bluetooth will soon be accessed by content/browser. This > change converts it from a static library to a shared component. > > BUG=438305 > > Committed: https://crrev.com/ff6eaf5adf4d6dc5a748e2ee4e8de080655d1975 > Cr-Commit-Position: refs/heads/master@{#307049} TBR=armansito@chromium.org,isherman@chromium.org,benchan@chromium.org NOTREECHECKS=true NOTRY=true BUG=438305 Committed: https://crrev.com/9f5b566d896d34380642c952041bfd30eb315385 Cr-Commit-Position: refs/heads/master@{#307098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -97 lines) Patch
M device/bluetooth/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +1 line, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter.h View 3 chunks +2 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.h View 2 chunks +2 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 2 chunks +2 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_discovery_session.h View 2 chunks +1 line, -2 lines 0 comments Download
D device/bluetooth/bluetooth_export.h View 1 chunk +0 lines, -28 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_characteristic.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_connection.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_descriptor.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_notify_session.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_service.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_init_win.h View 2 chunks +1 line, -3 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.h View 3 chunks +3 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_service_record_win.h View 1 chunk +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_socket.h View 2 chunks +1 line, -3 lines 0 comments Download
M device/bluetooth/bluetooth_socket_thread.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.h View 5 chunks +5 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_uuid.h View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheib
Created Revert of bluetooth: Make device/bluetooth a shared library component.
6 years ago (2014-12-05 22:30:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748873004/1
6 years ago (2014-12-05 22:31:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 22:32:44 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-05 22:33:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f5b566d896d34380642c952041bfd30eb315385
Cr-Commit-Position: refs/heads/master@{#307098}

Powered by Google App Engine
This is Rietveld 408576698