Issue 7488042: v8: Move DeleteEmpty test to test-list.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7488042: v8: Move DeleteEmpty test to test-list.cc (Closed)

Created:
9 years, 5 months ago by tfarina

Modified:
9 years, 5 months ago

Reviewers:
mnaganov (inactive)

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@trunk

Visibility:
Public.

Description

v8: Move DeleteEmpty test to test-list.cc BUG=None TEST=None Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://code.google.com/p/v8/source/detail?r=8728

Patch Set 1 : #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	test/cctest/test-ast.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download
	M	test/cctest/test-list.cc	View		2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

Is there trybots for v8 that I could use? I can commit this myself? I ...

9 years, 5 months ago (2011-07-23 23:11:07 UTC) #1

mnaganov (inactive)

9 years, 5 months ago (2011-07-24 17:43:44 UTC) #2

On 2011/07/23 23:11:07, tfarina wrote:
> Is there trybots for v8 that I could use?
> 
> I can commit this myself?
> 
> I see that there is a buildbot for v8 here ->
> http://build.chromium.org/p/client.v8/waterfall
> 
> Please, take a look.

LGTM.

No, V8 doesn't have trybots. And Chromium committers are not automatically
allowed to commit into V8.

I will commit this.

Expand Messages | Collapse Messages