Fixed Gyp Xcode generator for libraries with identical names.

pylib/gyp/generator/xcode.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import filecmp
 import gyp.common
 import gyp.xcodeproj_file
 import gyp.xcode_ninja
 import errno
 import os
@@ skipping 95 matching lines @@
 
 class XcodeProject(object):
   def __init__(self, gyp_path, path, build_file_dict):
     self.gyp_path = gyp_path
     self.path = path
     self.project = gyp.xcodeproj_file.PBXProject(path=path)
     projectDirPath = gyp.common.RelativePath(
                          os.path.dirname(os.path.abspath(self.gyp_path)),
                          os.path.dirname(path) or '.')
     self.project.SetProperty('projectDirPath', projectDirPath)
+    if 'xcode_settings' in build_file_dict:
+      xcs = build_file_dict['xcode_settings']
+      # Only avoid add projectRoot to avoid hash collision, if both SYMROOT

[Mark Mentovai, 2014/11/25 15:59:31]

I don’t really understand this comment.

+      # and CONFIGURATION_BUILD_DIR are set. Otherwise ignore everything.
+      if 'SYMROOT' in xcs and 'CONFIGURATION_BUILD_DIR' in xcs:

[Mark Mentovai, 2014/11/25 15:59:31]

I also don’t know how or why you’ve chosen this condition to dictate the
behavior.

+        self.project.SetProperty('projectRoot', os.path.dirname(path))

[Mark Mentovai, 2014/11/25 15:59:31]

What is path here? Absolute or relative?

[Mark Mentovai, 2014/11/25 15:59:31]

Is projectRoot a real thing that Xcode ever sets? If not, I don’t think we
should leave it someplace that it’ll show up in the output.

+      elif 'SYMROOT' not in xcs and 'CONFIGURATION_BUILD_DIR' not in xcs:
+        pass
+      else:
+        sys.stderr.write("Warning: Only one of 'SYMROOT' and \
+          'CONFIGURATION_BUILD_DIR' defined in %s. Either define both or none" %

[Mark Mentovai, 2014/11/25 15:59:31]

Where does this requirement come from?

+          gyp_path)
+        pass

[Mark Mentovai, 2014/11/25 15:59:31]

Not needed since you already have the (questionable) sys.stderr.write.

     self.project_file = \
         gyp.xcodeproj_file.XCProjectFile({'rootObject': self.project})
     self.build_file_dict = build_file_dict
 
     # TODO(mark): add destructor that cleans up self.path if created_dir is
     # True and things didn't complete successfully.  Or do something even
     # better with "try"?
     self.created_dir = False
     try:
       os.makedirs(self.path)
@@ skipping 1108 matching lines @@
 
   for build_file in build_files:
     xcode_projects[build_file].Finalize1(xcode_targets, serialize_all_tests)
 
   for build_file in build_files:
     xcode_projects[build_file].Finalize2(xcode_targets,
                                          xcode_target_to_target_dict)
 
   for build_file in build_files:
     xcode_projects[build_file].Write()