Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 748733002: Revert of SkCanvas::clear() should call down to devices even when the clip is empty. (Closed)

Created:
6 years, 1 month ago by f(malita)
Modified:
6 years, 1 month ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
reviews_skia.org, humper
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of SkCanvas::clear() should call down to devices even when the clip is empty. (patchset #1 id:1 of https://codereview.chromium.org/735233003/) Reason for revert: Chrome unit_tests failures on Mac & Win, blocking the roll: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/5613 Original issue's description: > SkCanvas::clear() should call down to devices even when the clip is empty. > > SkDrawIter had a lovely, completely unused, option for this. Oversight? > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/378e70d8e561b72a904286ea231946f5c8345b9a TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/8ebaa7171246eb5b3a7dd65ba42ef42a888508d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
f(malita)
Created Revert of SkCanvas::clear() should call down to devices even when the clip is empty.
6 years, 1 month ago (2014-11-21 04:43:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748733002/1
6 years, 1 month ago (2014-11-21 04:43:55 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 04:44:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8ebaa7171246eb5b3a7dd65ba42ef42a888508d7

Powered by Google App Engine
This is Rietveld 408576698