Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 748723002: Move content_settings_custom_extension_provider.* to c/b/extensions/api/content_settings/ (Closed)

Created:
6 years, 1 month ago by Sunil Ratnu
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move content_settings_custom_extension_provider.* to c/b/extensions/api/content_settings/ This CL moves content_settings_custom_extension_provider.* to chrome/browser/extensions/api/content_settings/. The detailed discussion can be seen here: https://code.google.com/p/chromium/issues/detail?id=393202 BUG=384868 Committed: https://crrev.com/21b896c69fa515ec727ce45e6e4b538d12c4559d Cr-Commit-Position: refs/heads/master@{#305408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -125 lines) Patch
D chrome/browser/content_settings/content_settings_custom_extension_provider.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/content_settings/content_settings_custom_extension_provider.cc View 1 chunk +0 lines, -59 lines 0 comments Download
A + chrome/browser/extensions/api/content_settings/content_settings_custom_extension_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/content_settings/content_settings_custom_extension_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Sunil Ratnu
Please review this. Thanks! Sunil
6 years, 1 month ago (2014-11-21 04:29:30 UTC) #3
vabr (Chromium)
Thanks, Sunil Ratnu. This LGTM. Vaclav
6 years, 1 month ago (2014-11-21 09:36:14 UTC) #4
not at google - send to devlin
Thanks for doing this! lgtm.
6 years, 1 month ago (2014-11-21 21:08:05 UTC) #5
Sunil Ratnu
On 2014/11/21 21:08:05, kalman wrote: > Thanks for doing this! lgtm. Hi Marcus, Could you ...
6 years ago (2014-11-24 09:16:07 UTC) #6
markusheintz_
On 2014/11/24 09:16:07, Sunil Ratnu wrote: > On 2014/11/21 21:08:05, kalman wrote: > > Thanks ...
6 years ago (2014-11-24 09:25:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748723002/1
6 years ago (2014-11-24 09:26:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 10:09:34 UTC) #10
commit-bot: I haz the power
6 years ago (2014-11-24 10:10:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21b896c69fa515ec727ce45e6e4b538d12c4559d
Cr-Commit-Position: refs/heads/master@{#305408}

Powered by Google App Engine
This is Rietveld 408576698