Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 748673002: Fix the compilation issue for turbofan unsupported backend. (Closed)

Created:
6 years, 1 month ago by chunyang.dai
Modified:
6 years ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix the compilation issue for turbofan unsupported backend which is introduced by https://chromium.googlesource.com/v8/v8/+/aed26c05a50b2a1257ef8accc67143825f2e1f60. ( [turbofan] Clean up and factor out branch generation logic.) BUG= Committed: https://chromium.googlesource.com/v8/v8/+/0cd0231fbe234848bb6443c21e6a3cb470c0d36a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/compiler/code-generator.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
chunyang.dai
Hello, Titzer, PTAL. Thanks.
6 years, 1 month ago (2014-11-21 02:38:53 UTC) #2
titzer
lgtm
6 years ago (2014-11-21 08:53:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748673002/1
6 years ago (2014-11-21 08:54:27 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-21 09:22:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698