Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: sky/engine/core/BUILD.gn

Issue 748643002: Fix gn check //sky/* to pass again. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/BUILD.gn
diff --git a/sky/engine/core/BUILD.gn b/sky/engine/core/BUILD.gn
index b8949a3880f52b3e71c1d4fd08fdc02c83a29a23..8619f38c9bbeb70cb7c44d47904c8e51752bf34b 100644
--- a/sky/engine/core/BUILD.gn
+++ b/sky/engine/core/BUILD.gn
@@ -72,6 +72,9 @@ static_library("core") {
forward_dependent_configs_from = [
":libraries",
]
+
+ # core and core_generated are really the same thing.
+ allow_circular_includes_from = [ ":core_generated" ]
}
source_set("testing") {
@@ -124,11 +127,12 @@ source_set("core_generated") {
":prerequisites",
"//gin",
"//skia",
+ "//sky/engine/bindings/core/v8:bindings_core_v8_generated",
+ "//sky/engine/platform",
+ "//sky/engine/wtf",
"//third_party/iccjpeg",
"//third_party/libpng",
"//third_party/qcms",
- "//sky/engine/bindings/core/v8:bindings_core_v8_generated",
- "//sky/engine/wtf",
"//url",
"//v8",
]
« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698