Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: PRESUBMIT.py

Issue 748643002: Fix gn check //sky/* to pass again. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 0c36faa51713fad797b1a24ff3be2c2375d8690d..951b98143d0eb948c2f330f8604fdfb0c130c21c 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -449,14 +449,10 @@ def _CheckGNCheck(input_api, output_api):
'//mojo/public/*',
'//mojo/tools/*',
]
- # TODO(eseidel): //sky is temporarily broken during the process of
- # making all of our headers aboslute. crbug.com/435361
- # Now that they're absolute gn understands our includes and our previous
- # passing of gn check was a total lie.
- # if input_api.platform != 'win32':
- # KNOWN_PASSING += [
- # '//sky/*',
- # ]
+ if input_api.platform != 'win32':
+ KNOWN_PASSING += [
+ '//sky/*',
+ ]
for target_filter in KNOWN_PASSING:
try:
input_api.subprocess.check_output(['gn', 'check', relative_out_dir,
« no previous file with comments | « no previous file | sky/engine/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698