Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: PRESUBMIT.py

Issue 748643002: Fix gn check //sky/* to pass again. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/engine/core/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 'gn gen must not fail.', long_text=error.output)] 442 'gn gen must not fail.', long_text=error.output)]
443 443
444 # TODO(eseidel): Currently only these are known to pass, 444 # TODO(eseidel): Currently only these are known to pass,
445 # once everything passes we can just call 'gn check' once without a filter! 445 # once everything passes we can just call 'gn check' once without a filter!
446 KNOWN_PASSING = [ 446 KNOWN_PASSING = [
447 '//mojo/edk/*', 447 '//mojo/edk/*',
448 '//mojo/gpu/*', 448 '//mojo/gpu/*',
449 '//mojo/public/*', 449 '//mojo/public/*',
450 '//mojo/tools/*', 450 '//mojo/tools/*',
451 ] 451 ]
452 # TODO(eseidel): //sky is temporarily broken during the process of 452 if input_api.platform != 'win32':
453 # making all of our headers aboslute. crbug.com/435361 453 KNOWN_PASSING += [
454 # Now that they're absolute gn understands our includes and our previous 454 '//sky/*',
455 # passing of gn check was a total lie. 455 ]
456 # if input_api.platform != 'win32':
457 # KNOWN_PASSING += [
458 # '//sky/*',
459 # ]
460 for target_filter in KNOWN_PASSING: 456 for target_filter in KNOWN_PASSING:
461 try: 457 try:
462 input_api.subprocess.check_output(['gn', 'check', relative_out_dir, 458 input_api.subprocess.check_output(['gn', 'check', relative_out_dir,
463 target_filter]) 459 target_filter])
464 except input_api.subprocess.CalledProcessError, error: 460 except input_api.subprocess.CalledProcessError, error:
465 error_title = 'gn check %s must not fail.' % target_filter 461 error_title = 'gn check %s must not fail.' % target_filter
466 return [output_api.PresubmitError(error_title, long_text=error.output)] 462 return [output_api.PresubmitError(error_title, long_text=error.output)]
467 return [] 463 return []
468 464
469 465
(...skipping 1299 matching lines...) Expand 10 before | Expand all | Expand 10 after
1769 builders.extend(['cros_x86']) 1765 builders.extend(['cros_x86'])
1770 1766
1771 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1767 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1772 # unless they're .gyp(i) files as changes to those files can break the gyp 1768 # unless they're .gyp(i) files as changes to those files can break the gyp
1773 # step on that bot. 1769 # step on that bot.
1774 if (not all(re.search('^chrome', f) for f in files) or 1770 if (not all(re.search('^chrome', f) for f in files) or
1775 any(re.search('\.gypi?$', f) for f in files)): 1771 any(re.search('\.gypi?$', f) for f in files)):
1776 builders.extend(['android_aosp']) 1772 builders.extend(['android_aosp'])
1777 1773
1778 return GetDefaultTryConfigs(builders) 1774 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | sky/engine/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698