Issue 748643002: Fix gn check //sky/* to pass again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 748643002: Fix gn check //sky/* to pass again. (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+4 lines, -8 lines	0 comments	Download
	M	sky/engine/core/BUILD.gn	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

eseidel

6 years, 1 month ago (2014-11-21 01:56:41 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8db2357accd9c3c854a6bfb6c744d79b5c47a573 (presubmit successful).