LayoutTests/scrollbars/custom-scrollbarthumb-inactive-pseudo.html - Issue 748513006: Trigger style recalc when the window's active state change

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/scrollbars/custom-scrollbarthumb-inactive-pseudo.html

Issue 748513006: Trigger style recalc when the window's active state change (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Invalidatin all the CustomScrolllbars on window-inactive Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/scrollbars/custom-scrollbarthumb-inactive-pseudo-expected.html » ('j') | LayoutTests/scrollbars/custom-scrollbarthumb-inactive-pseudo-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <style>

	3 ::-webkit-scrollbar {

	4 width: 12px;

	5 height: 12px;

	6 }

	7 ::-webkit-scrollbar-track {

	8 -webkit-box-shadow: inset 0 0 6px rgba(0,0,0,0.3);

	9 -webkit-border-radius: 10px;

	10 border-radius: 10px;

	11 }

	12 ::-webkit-scrollbar-thumb {

	13 -webkit-border-radius: 10px;

	14 border-radius: 10px;

	15 background: rgba(255,0,0,0.8);

	16 -webkit-box-shadow: inset 0 0 6px rgba(0,0,0,0.5);

	17 }

	18 ::-webkit-scrollbar-thumb:window-inactive {

	19 background: rgba(255,150,250,0.8);

	20 }

	21 html {

	22 overflow: scroll;

	23 }

	24 body {

	25 width: 1000px;
	pdr. 2014/12/06 04:17:53 Nit: Please fix the indentation in the tests. 8 or Nit: Please fix the indentation in the tests. 8 or 4 or 2 spaces are fine as long as we're consistent in a file. MuVen 2014/12/06 13:27:03 Done. Show quoted text On 2014/12/06 04:17:53, pdr wrote: > Nit: Please fix the indentation in the tests. 8 or 4 or 2 spaces are fine as > long as we're consistent in a file. Done.
	26 height: 1000px;

	27 }

	28 div {

	29 width: 100px;

	30 height: 100px;

	31 overflow: scroll;

	32 }

	33 </style>

	34 <body>

	35 <iframe src="resources/scrollable-iframe.html"></iframe>

	36 <iframe src="resources/scrollable-iframe.html"></iframe>

	37 <div><p style="width:200px;height:200px"></p></div>

	38 </body>

	39 <script>

	40 if (window.testRunner)

	41 testRunner.waitUntilDone();

	42 function changeFocus() {

	43 // setWindowIsKey shall set the focus of the window.

	44 if (window.testRunner)

	45 window.testRunner.setWindowIsKey(false);

	46 if (window.testRunner)

	47 window.testRunner.notifyDone();

	48 }

	49 setTimeout(function(){ changeFocus(); }, 100);
	pdr. 2014/12/06 04:17:53 This timeout doesn't seem right. Was this added so This timeout doesn't seem right. Was this added so that the iframes have time to load? If so, that'll unfortunately lead to flakiness on our very slow bots (win-dbg) and slow tests on our fast bots (linux-rel). Something like this should work without settimeout: window.onload = function() { if (window.testRunner) { testRunner.setWindowsIsKey(false); } } MuVen 2014/12/06 13:27:03 Done. Show quoted text On 2014/12/06 04:17:53, pdr wrote: > This timeout doesn't seem right. Was this added so that the iframes have time to > load? If so, that'll unfortunately lead to flakiness on our very slow bots > (win-dbg) and slow tests on our fast bots (linux-rel). Something like this > should work without settimeout: > window.onload = function() { > if (window.testRunner) { > testRunner.setWindowsIsKey(false); > } > } Done.
	50 </script>

OLD	NEW