Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 748453002: tools/clang: ui_unittests -> ui_base_unittests (Closed)

Created:
6 years, 1 month ago by tfarina
Modified:
6 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

tools/clang: ui_unittests -> ui_base_unittests Then we will proceed to remove the ui_unittests target in the next CL. BUG=331829, 373148, 299841, 103304 R=thakis@chromium.org Committed: https://crrev.com/a55f7179676dd51eddc0133770e9041e545875a3 Cr-Commit-Position: refs/heads/master@{#305068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/plugins/ChromeClassTester.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
6 years, 1 month ago (2014-11-20 17:57:15 UTC) #1
Nico
lgtm
6 years, 1 month ago (2014-11-20 18:05:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748453002/1
6 years, 1 month ago (2014-11-20 19:13:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 19:57:09 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 19:57:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a55f7179676dd51eddc0133770e9041e545875a3
Cr-Commit-Position: refs/heads/master@{#305068}

Powered by Google App Engine
This is Rietveld 408576698