Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 7484051: Merging SPDY IP connection pooling changes from the trunk (r93105) (Closed)

Created:
9 years, 5 months ago by ramant (doing other things)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merging SPDY IP connection pooling changes from the trunk (r93105) Changed SPDY's ip connection pooling logic to only add the used IP, rather than all the IPs for the hostname, to the SpdyAliasMap. This is to fix the following problem: When we establish a new SPDY connection, we add all IP addresses for that hostname to our alias map. Therefore, if we connect to host foo which maps to IPs X, Y, and Z, but the actual IP we connect to is X, then if we try to get a SPDY connection to host bar which maps to IPs Y and Z, then currently we will share the SPDY connection to host foo on IP X. BUG=89094 R=willchan,wtc TEST=spdy unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93801

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -56 lines) Patch
M net/http/http_network_transaction_unittest.cc View 6 chunks +41 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 5 chunks +13 lines, -4 lines 0 comments Download
M net/spdy/spdy_session_pool.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session_pool.cc View 3 chunks +20 lines, -30 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M net/spdy/spdy_test_util.h View 1 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
Hi Wan-Teh, I have merged the changes from the following CL into the branch. Added ...
9 years, 5 months ago (2011-07-22 23:39:30 UTC) #1
willchan no longer on Chromium
On 2011/07/22 23:39:30, ramant wrote: > Hi Wan-Teh, > I have merged the changes from ...
9 years, 5 months ago (2011-07-23 09:40:46 UTC) #2
wtc
9 years, 5 months ago (2011-07-25 18:56:07 UTC) #3
LGTM.  I only reviewed spdy_session_pool.{cc,h}.

Powered by Google App Engine
This is Rietveld 408576698