Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 748193002: Add the Stability.BrowserExitCodes metric and a couple of relevant exit codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@watcher_tieup
Patch Set: Address Erik's and Mark's comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f902aaaf677b7dc128e7ad81fae110e3d50117ce..c0f39a8221b29af28156f2b305fcc9539d8149ee 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -35128,6 +35128,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="Stability.BrowserExitCodes" enum="WindowsExitCode">
+ <owner>siggi@chromium.org</owner>
+ <owner>erikwright@chromium.org</owner>
+ <summary>
+ Records the exit code of the browser process (on Windows) from the previous
+ launch. On crash, the exit code will indicate the exception code of the
+ crash. This is emitted in stability data with the first report on a
+ subsequent launch.
+ </summary>
+</histogram>
+
<histogram name="Stars.Goog_Related" units="percent">
<owner>yefim@chromium.org</owner>
<summary>
@@ -56391,6 +56402,14 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="3" label="Desktop Aura"/>
</enum>
+<enum name="WindowsExitCode" type="int">
+ <int value="0" label="Success"/>
+ <int value="1" label="Error"/>
+ <int value="3221225477" label="Access Violation"/>
+<!-- TODO(siggi): Add other values here at need. -->
+
+</enum>
+
<enum name="WindowsVersion" type="int">
<int value="0" label="Pre-XP"/>
<int value="1" label="XP"/>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698