tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f902aaaf677b7dc128e7ad81fae110e3d50117ce..aaee21440bd56840cc086d6db1394a684a77195b 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -35128,6 +35128,16 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Stability.BrowserExitCodes" enum="WindowsExitCode">

[Mark P, 2014/11/21 20:48:41]

Do you plan that this is always a Windows-only histogram?  If so, why did you
name the histogram as this?  If not, why are you naming the enum this?

[Sigurður Ásgeirsson, 2014/11/21 21:59:31]

Yes, I expect this'll be Windows only. On sane OSen, we shouldn't need this, as
we can haz sane crash capture there.

+  <owner>siggi@chromium.org</owner>
+  <owner>erikwright@chromium.org</owner>
+  <summary>
+    Records the exit code of browser process (on Windows) from the previous

[erikwright (departed), 2014/11/21 20:41:10]

of browser -> of the browser

[Sigurður Ásgeirsson, 2014/11/21 21:59:31]

Done.

+    launch. On crash, the exit code will indicate the exception code of the

[Mark P, 2014/11/21 20:48:41]

Please explain directly when this is emitted.  e.g., Emitted shortly after
startup on the following launch.

[Sigurður Ásgeirsson, 2014/11/21 21:59:31]

Done.

+    crash.
+  </summary>
+</histogram>
+
 <histogram name="Stars.Goog_Related" units="percent">
   <owner>yefim@chromium.org</owner>
   <summary>
@@ -56391,6 +56401,14 @@ To add a new entry, add it with any value and run test to compute valid value.
   <int value="3" label="Desktop Aura"/>
 </enum>
 
+<enum name="WindowsExitCode" type="int">
+  <int value="0" label="Success"/>
+  <int value="1" label="Error"/>
+  <int value="3221225477" label="Access Violation"/>
+<!-- TODO(siggi): Add other values here at need. -->

[erikwright (departed), 2014/11/21 20:41:10]

indentation?

[Sigurður Ásgeirsson, 2014/11/21 21:59:31]

The presubmit check for this file wants precisely this indentation.

+
+</enum>
+
 <enum name="WindowsVersion" type="int">
   <int value="0" label="Pre-XP"/>
   <int value="1" label="XP"/>