Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1819)

Unified Diff: build/android/pylib/gtest/test_package_apk.py

Issue 748143003: [Android] Change how we write command line files for gtest APKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/test_package_apk.py
diff --git a/build/android/pylib/gtest/test_package_apk.py b/build/android/pylib/gtest/test_package_apk.py
index 4a9127856731cc2df03f2dd4e69c1b95e5031910..67571a4a4f98e9149edda9a03bbaaebe9d81e5db 100644
--- a/build/android/pylib/gtest/test_package_apk.py
+++ b/build/android/pylib/gtest/test_package_apk.py
@@ -40,13 +40,8 @@ class TestPackageApk(TestPackage):
self._package_info = constants.PACKAGE_INFO['gtest']
def _CreateCommandLineFileOnDevice(self, device, options):
- command_line_file = tempfile.NamedTemporaryFile()
- # GTest expects argv[0] to be the executable path.
- command_line_file.write(self.suite_name + ' ' + options)
- command_line_file.flush()
- device.PushChangedFiles([(
- command_line_file.name,
- self._package_info.cmdline_file)])
+ device.WriteFile(self._package_info.cmdline_file,
+ self.suite_name + ' ' + options)
def _GetFifo(self):
# The test.fifo path is determined by:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698