Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: test/mjsunit/harmony/block-conflicts.js

Issue 748113003: harmony-scoping: Catch variable should be VAR, not LET (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/parser.cc ('k') | test/mjsunit/harmony/regress/regress-2858.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Use of this source code is governed by a BSD-style license that can be
3 // modification, are permitted provided that the following conditions are 3 // found in the LICENSE file.
4 // met:
5 // 4 //
6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission.
15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27
28 // Flags: --harmony-scoping 5 // Flags: --harmony-scoping
29 6
30 // Test for conflicting variable bindings. 7 // Test for conflicting variable bindings.
31 8
32 "use strict"; 9 "use strict";
33 10
34 function CheckException(e) { 11 function CheckException(e) {
35 var string = e.toString(); 12 var string = e.toString();
36 assertTrue(string.indexOf("has already been declared") >= 0 || 13 assertTrue(string.indexOf("has already been declared") >= 0 ||
37 string.indexOf("redeclaration") >= 0); 14 string.indexOf("redeclaration") >= 0);
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 TestLocalConflict(funbind + '{' + varbinds[v] + '}'); 145 TestLocalConflict(funbind + '{' + varbinds[v] + '}');
169 TestLocalConflict('{' + varbinds[v] +'}' + funbind); 146 TestLocalConflict('{' + varbinds[v] +'}' + funbind);
170 TestNoConflict(varbinds[v] + '{' + funbind + '}'); 147 TestNoConflict(varbinds[v] + '{' + funbind + '}');
171 TestNoConflict('{' + funbind + '}' + varbinds[v]); 148 TestNoConflict('{' + funbind + '}' + varbinds[v]);
172 // For loop. 149 // For loop.
173 TestNoConflict('for (' + varbinds[v] + '0;) {' + funbind + '}'); 150 TestNoConflict('for (' + varbinds[v] + '0;) {' + funbind + '}');
174 } 151 }
175 152
176 // Test conflicting catch/var bindings. 153 // Test conflicting catch/var bindings.
177 for (var v = 0; v < varbinds.length; ++v) { 154 for (var v = 0; v < varbinds.length; ++v) {
178 TestConflict('try {} catch(x) {' + varbinds[v] + '}'); 155 TestNoConflict('try {} catch(x) {' + varbinds[v] + '}');
179 } 156 }
180 157
181 // Test conflicting parameter/var bindings. 158 // Test conflicting parameter/var bindings.
182 for (var v = 0; v < varbinds.length; ++v) { 159 for (var v = 0; v < varbinds.length; ++v) {
183 TestNoConflict('(function (x) {' + varbinds[v] + '})();'); 160 TestNoConflict('(function (x) {' + varbinds[v] + '})();');
184 } 161 }
185 162
186 // Test conflicting catch/function bindings. 163 // Test conflicting catch/function bindings.
187 TestNoConflict('try {} catch(x) {' + funbind + '}'); 164 TestNoConflict('try {} catch(x) {' + funbind + '}');
188 165
189 // Test conflicting parameter/function bindings. 166 // Test conflicting parameter/function bindings.
190 TestNoConflict('(function (x) {' + funbind + '})();'); 167 TestNoConflict('(function (x) {' + funbind + '})();');
OLDNEW
« no previous file with comments | « src/parser.cc ('k') | test/mjsunit/harmony/regress/regress-2858.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698