Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 748113003: harmony-scoping: Catch variable should be VAR, not LET (Closed)

Created:
6 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

harmony-scoping: Catch variable should be VAR, not LET R=rossberg@chromium.org BUG=v8:2858 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M src/parser.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/harmony/block-conflicts.js View 2 chunks +3 lines, -26 lines 0 comments Download
A test/mjsunit/harmony/regress/regress-2858.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dmitry Lomov (no reviews)
PTAL.
6 years, 1 month ago (2014-11-21 23:02:10 UTC) #1
rossberg
lgtm
6 years ago (2014-11-25 14:30:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748113003/1
6 years ago (2014-11-25 14:33:21 UTC) #4
commit-bot: I haz the power
6 years ago (2014-11-25 14:48:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698