Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 748073003: Revert of use (num_cores/2) jobs by default for telemetry unittests. (Closed)

Created:
6 years, 1 month ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke, dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of use (num_cores/2) jobs by default for telemetry unittests. (patchset #1 id:1 of https://codereview.chromium.org/742373002/) Reason for revert: May be causing failures on XP Tests bot: https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1) First failure here: https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/34002 Speculative revert after discussions. Original issue's description: > use (num_cores/2) jobs by default for telemetry unittests. > > Previously we were using (num_cores/4). Let's see if we can get more > parallelism and still not overload the machine. > > R=dtu@chromium.org > BUG=388256 > > Committed: https://crrev.com/4866abd7d1c6bfeb520ccd74ffb730ed45dd3cf3 > Cr-Commit-Position: refs/heads/master@{#305163} TBR=dtu@chromium.org,tonyg@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=388256 Committed: https://crrev.com/d5ab562fd38ae1591536c7f85fa8c81a05145370 Cr-Commit-Position: refs/heads/master@{#305231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/unittest_util/run_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Roger Tawa OOO till Jul 10th
Created Revert of use (num_cores/2) jobs by default for telemetry unittests.
6 years, 1 month ago (2014-11-21 17:28:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748073003/1
6 years, 1 month ago (2014-11-21 17:29:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 17:30:34 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 17:31:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5ab562fd38ae1591536c7f85fa8c81a05145370
Cr-Commit-Position: refs/heads/master@{#305231}

Powered by Google App Engine
This is Rietveld 408576698