Use a StyleBuilderConverter function for line-height.

Use a StyleBuilderConverter function for line-height.

The line-height property does not need a custom StyleBuilder function (at
least not anymore).

R=timloh@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185867

[andersr, 2014-11-21 16:29:15]

https://codereview.chromium.org/748073002/diff/1/Source/core/css/resolver/Sty...
File Source/core/css/resolver/StyleBuilderCustom.cpp (left):

https://codereview.chromium.org/748073002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StyleBuilderCustom.cpp:328: lineHeight =
Length(valueForLength(zoomedLength, state.style()->fontSize()), Fixed);
Calc resolves against RenderStyle::fontSize, but percentage resolves against
RenderStyle::computedFontSize? Can that be right?

[Timothy Loh, 2014-11-21 17:13:02]

lgtm

https://codereview.chromium.org/748073002/diff/1/Source/core/css/resolver/Sty...
File Source/core/css/resolver/StyleBuilderCustom.cpp (left):

https://codereview.chromium.org/748073002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StyleBuilderCustom.cpp:328: lineHeight =
Length(valueForLength(zoomedLength, state.style()->fontSize()), Fixed);
On 2014/11/21 16:29:15, andersr wrote:
> Calc resolves against RenderStyle::fontSize, but percentage resolves against
> RenderStyle::computedFontSize? Can that be right?

Sounds wrong, but I wouldn't fix it in this patch. Maybe makes sense to merge
the length/percent/calc cases and just call convertLength then valueForLength in
all these cases (in a separate patch).

[andersr, 2014-11-24 09:40:29]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-11-24 09:42:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/748073002/1

[commit-bot: I haz the power, 2014-11-24 10:52:38]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185867