Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 748063003: Clean up FreeType code for 2.3.8. (Closed)

Created:
6 years, 1 month ago by bungeman-skia
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Clean up FreeType code for 2.3.8. We already require FreeType 2.3.8 in order to compile and run. Make this requirement explicit and take advantage of it. Committed: https://skia.googlesource.com/skia/+/5ec443c506ed5b180018091c2d192e013dfb44ce

Patch Set 1 #

Patch Set 2 : Already assuming FT_LCD_FILTER_H is defined. #

Total comments: 4

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -100 lines) Patch
M gyp/freetype.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 2 17 chunks +33 lines, -97 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
bungeman-skia
While debugging something in SkFontHost_FreeType I became uncomfortable with the amount of cruft. Hopefully this ...
6 years, 1 month ago (2014-11-21 19:18:52 UTC) #2
bungeman-skia
6 years, 1 month ago (2014-11-21 20:32:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748063003/20001
6 years, 1 month ago (2014-11-21 20:41:20 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-21 20:41:20 UTC) #7
mtklein
https://codereview.chromium.org/748063003/diff/20001/src/ports/SkFontHost_FreeType.cpp File src/ports/SkFontHost_FreeType.cpp (right): https://codereview.chromium.org/748063003/diff/20001/src/ports/SkFontHost_FreeType.cpp#newcode100 src/ports/SkFontHost_FreeType.cpp:100: SkDEBUGCODE(gFTMutex.assertHeld()); Isn't the body of assertHeld() itself SkDEBUGCODE? https://codereview.chromium.org/748063003/diff/20001/src/ports/SkFontHost_FreeType.cpp#newcode1253 ...
6 years, 1 month ago (2014-11-21 21:00:03 UTC) #8
bungeman-skia
https://codereview.chromium.org/748063003/diff/20001/src/ports/SkFontHost_FreeType.cpp File src/ports/SkFontHost_FreeType.cpp (right): https://codereview.chromium.org/748063003/diff/20001/src/ports/SkFontHost_FreeType.cpp#newcode100 src/ports/SkFontHost_FreeType.cpp:100: SkDEBUGCODE(gFTMutex.assertHeld()); On 2014/11/21 21:00:03, mtklein wrote: > Isn't the ...
6 years, 1 month ago (2014-11-21 21:07:43 UTC) #9
mtklein
lgtm
6 years, 1 month ago (2014-11-21 21:08:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/748063003/40001
6 years, 1 month ago (2014-11-21 21:08:50 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 21:18:39 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5ec443c506ed5b180018091c2d192e013dfb44ce

Powered by Google App Engine
This is Rietveld 408576698