Better error messages on archive failures, and stop running with partial page sets in user_story_ru…

tools/telemetry/telemetry/user_story/user_story_runner_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 import StringIO
 import sys
 
 from telemetry import benchmark
 from telemetry import user_story
 from telemetry.core import exceptions
+from telemetry.page import page_set
 from telemetry.page import page_test
 from telemetry.page import test_expectations
 from telemetry.results import results_options
+from unittest_data import test_simple_one_page_set
 from telemetry.unittest_util import options_for_unittests
 from telemetry.unittest_util import system_stub
 from telemetry.user_story import shared_user_story_state
 from telemetry.user_story import user_story_runner
 from telemetry.user_story import user_story_set
 from telemetry.util import exception_formatter as exception_formatter_module
 from telemetry.value import scalar
 from telemetry.value import string
 
 # This linter complains if we define classes nested inside functions.
@@ skipping 308 matching lines @@
           Measurement(), us, self.expectations, self.options, results)
       results.PrintSummary()
       contents = output.getvalue()
       self.assertEquals(4, GetNumberOfSuccessfulPageRuns(results))
       self.assertEquals(0, len(results.failures))
       self.assertIn('RESULT metric: blank= [1,3] unit', contents)
       self.assertIn('RESULT metric: green= [2,4] unit', contents)
       self.assertIn('*RESULT metric: metric= [1,2,3,4] unit', contents)
     finally:
       sys.stdout = real_stdout
+
+  def testCheckArchives(self):
+    ps = page_set.PageSet()

[nednguyen, 2014/12/03 18:27:43]

If this test use real page_set, it shouldn't be in user_story_unittest. Also
please file a way to test this without touching the real network.

[aiolos (Not reviewing), 2014/12/04 00:29:31]

Is this something I should be considering still? I didn't see a response to it.

[nednguyen, 2014/12/04 05:17:31]

Yes, my bad. Please ignore the original comment.

+    # Empty page set.
+    self.assertFalse(user_story_runner._CheckArchives(ps, ps.pages))
+    ps.AddPageWithDefaultRunNavigate('http://127.0.0.1:62350/blank.html')

[nednguyen, 2014/12/03 19:35:59]

Is there any reason why you choose 'http://127.0.0.1:62350/blank.html' instead
of a bogus url? If not, please change the url so it easier to reason about the
testing logic.

[aiolos (Not reviewing), 2014/12/04 00:29:31]

I pulled it from an existing test page set. I don't think it matters if we use
this or not. Done.

+    # Page set missing archive_data_file.
+    self.assertFalse(user_story_runner._CheckArchives(ps, ps.pages))
+
+    ps = page_set.PageSet(archive_data_file='missing_archive_data_file.json')
+    ps.AddPageWithDefaultRunNavigate('http://127.0.0.1:62350/blank.html')
+    # Page set missing json file specified in archive_data_file.
+    self.assertFalse(user_story_runner._CheckArchives(ps, ps.pages))
+
+    ps = page_set.PageSet(archive_data_file='../../unittest_data/test.json',
+                          bucket=page_set.PUBLIC_BUCKET)
+    self.assertFalse(user_story_runner._CheckArchives(ps, ps.pages))
+    # Empty page set with an archive_data_file which exists.
+    ps.AddPageWithDefaultRunNavigate('http://127.0.0.1:62350/blank.html')
+    # Page set with valid archive_data_file.
+    self.assertTrue(user_story_runner._CheckArchives(ps, ps.pages))
+    ps.AddPageWithDefaultRunNavigate('http://www.google.com')
+    # Page set with an archive_data_file which exists but is missing a page.
+    self.assertFalse(user_story_runner._CheckArchives(ps, ps.pages))
+
+    ps = page_set.PageSet(
+        archive_data_file='../../unittest_data/test_missing_wpr_file.json',
+        bucket=page_set.PUBLIC_BUCKET)
+    ps.AddPageWithDefaultRunNavigate('http://127.0.0.1:62350/blank.html')
+    ps.AddPageWithDefaultRunNavigate('http://www.google.com')
+    # Page set with an archive_data_file which exists and contains all pages
+    # but fails to find a wpr file.
+    self.assertFalse(user_story_runner._CheckArchives(ps, ps.pages))