Issue 7480011: rename HCompareIDAndBranch to HCompareNumbersAndBranch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7480011: rename HCompareIDAndBranch to HCompareNumbersAndBranch (Closed)

Created:
9 years, 4 months ago by wingo

Modified:
7 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

rename HCompareIDAndBranch to HCompareNumbersAndBranch * src/hydrogen-instructions.h (HCompareNumbersAndBranch): Rename from HCompareIDAndBranch. It seems that "ID" stood for "integers or doubles", but to an ignorant reader (me) ID can be confused with "identities". * src/arm/lithium-arm.cc: * src/arm/lithium-arm.h: * src/hydrogen-instructions.cc: * src/hydrogen.cc: * src/ia32/lithium-ia32.cc: * src/ia32/lithium-ia32.h: * src/x64/lithium-x64.cc: * src/x64/lithium-x64.h: Adapt uses. BUG= TEST=

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -27 lines)			Patch
M	src/arm/lithium-arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	6 chunks	+14 lines, -12 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

wingo

9 years, 4 months ago (2011-07-26 14:46:45 UTC) #1

Feel free to reject this one, as it's just a name change.  The only reason I'm
posting it is that it took me quite some time to figure out what
HCompareIDAndBranch was for, and thought that a different name might help other
readers.

Expand Messages | Collapse Messages