src/ports/SkDiscardableMemory_none.cpp - Issue 74793011: Add SkImageGenerator Interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/ports/SkDiscardableMemory_none.cpp

Issue 74793011: Add SkImageGenerator Interface (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: protected destructor Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 /*	1 /*

2 * Copyright 2013 Google Inc.	2 * Copyright 2013 Google Inc.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7	7

8 #include "SkDiscardableMemory.h"	8 #include "SkBasicDiscardableMemory.h"

9	9

10 SkDiscardableMemory* SkDiscardableMemory::Create(size_t bytes) {	10 SkDiscardableMemory* SkDiscardableMemory::Create(size_t bytes) {

11 return NULL;	11 return SkBasicDiscardableMemory::Create(bytes);
	scroggo 2013/11/19 22:19:27 If we're going to do this, can we at least put a p If we're going to do this, can we at least put a printf that the actual memory is not discardable? hal.canary 2013/11/20 00:07:10 I don't like a lot of verbosity in my unit tests ( Show quoted text On 2013/11/19 22:19:27, scroggo wrote: > If we're going to do this, can we at least put a printf that the actual memory > is not discardable? I don't like a lot of verbosity in my unit tests (which is where this will be used). scroggo 2013/11/20 14:21:53 Fair enough. Here's my concern though. Someone can Show quoted text On 2013/11/20 00:07:10, Hal Canary wrote: > On 2013/11/19 22:19:27, scroggo wrote: > > If we're going to do this, can we at least put a printf that the actual memory > > is not discardable? > > I don't like a lot of verbosity in my unit tests (which is where this will be > used). Fair enough. Here's my concern though. Someone can call SkDiscardableMemory::Create(), expecting to get some memory that may be purged under memory pressure. Instead, they get something that never purges. That said, maybe this is fine, since the header is in src, and it makes no promises that it will ever be purged. I think Chrome doesn't build ports.gyp, so they shouldn't run into this problem.
12 }	12 }

OLD	NEW

« src/lazy/SkDiscardablePixelRef.cpp ('K') | « src/lazy/SkDiscardablePixelRef.cpp ('k') | tests/CachedDecodingPixelRefTest.cpp » ('j') | tests/CachedDecodingPixelRefTest.cpp » ('J')