Add SkImageGenerator Interface

src/core/SkBasicDiscardableMemory.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
-#ifndef SkDiscardableMemory_DEFINED
-#define SkDiscardableMemory_DEFINED
+#ifndef SkBasicDiscardableMemory_DEFINED
+#define SkBasicDiscardableMemory_DEFINED
 
-#include "SkTypes.h"
+#include "SkDiscardableMemory.h"
 
 /**
- *  Interface for discardable memory. Implementation is provided by the
- *  embedder.
+ *  Always successful, never purges
  */
-class SK_API SkDiscardableMemory {
-
+class SkBasicDiscardableMemory : public SkDiscardableMemory {

[reed1, 2013/11/19 22:01:18]

bikeshed: SkMallocDiscardableMemory?

[scroggo, 2013/11/19 22:19:27]

It seems dishonest to call this SkBasicDiscardableMemory, when really it's more
something like SkMockDiscardableMemory.

[hal.canary, 2013/11/20 00:07:10]

Done.

 public:
-    /**
-     *  Factory method that creates, initializes and locks an SkDiscardableMemory
-     *  object. If either of these steps fails, a NULL pointer will be returned.
-     */
-    static SkDiscardableMemory* Create(size_t bytes);
-
     /** Must not be called while locked.
      */
-    virtual ~SkDiscardableMemory() {}
+    virtual ~SkBasicDiscardableMemory();
 
     /**
      * Locks the memory, prevent it from being discarded. Once locked. you may

[scroggo, 2013/11/19 22:19:27]

Comments don't apply.

[hal.canary, 2013/11/20 00:07:10]

Done.

      * obtain a pointer to that memory using the data() method.

[reed1, 2013/11/19 22:01:18]

Not sure we should repeat the dox from the base-class. Perhaps better would be
dox about your subclass/impl if you want.

[hal.canary, 2013/11/20 00:07:10]

Done.

      *
      * lock() may return false, indicating that the underlying memory was
      * discarded and that the lock failed.
      *
      * Nested calls to lock are not allowed.
      */
-    virtual bool lock() = 0;
+    virtual bool lock() SK_OVERRIDE;
 
     /**
-     * Returns the current pointer for the discardable memory. This call is ONLY
-     * valid when the discardable memory object is locked.
+     * Returns the current pointer for the discardable memory. This
+     * call is ONLY valid when the discardable memory object is
+     * locked.
      */
-    virtual void* data() = 0;
+    virtual void* data() SK_OVERRIDE;
 
     /**
-     * Unlock the memory so that it can be purged by the system. Must be called
-     * after every successful lock call.
+     * Unlock the memory so that it can be purged by the system. Must
+     * be called after every successful lock call.
      */
-    virtual void unlock() = 0;
+    virtual void unlock() SK_OVERRIDE;
+
+    static SkDiscardableMemory* Create(size_t bytes);
+private:
+    bool fLocked;
+    void* fPointer;
+    SkBasicDiscardableMemory(void*);
 };
 
-#endif
+#endif  // SkBasicDiscardableMemory_DEFINED