webui: minimize webui flicker.

content/public/common/content_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_
 #define CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 46 matching lines @@
 
 // Used for tests to override the relevant embedder interfaces. Each method
 // returns the old value.
 CONTENT_EXPORT ContentBrowserClient* SetBrowserClientForTesting(
     ContentBrowserClient* b);
 CONTENT_EXPORT ContentRendererClient* SetRendererClientForTesting(
     ContentRendererClient* r);
 CONTENT_EXPORT ContentUtilityClient* SetUtilityClientForTesting(
     ContentUtilityClient* u);
 
+struct CONTENT_EXPORT WebUITextStyles {

[davidben, 2014/11/25 22:26:25]

Should this be in its own header? It's pretty tiny, but
http://www.chromium.org/developers/content-module/content-api does say to put
every struct in its own header. (I guess if I were looking for WebUITestStyles,
I wouldn't think to put it in there. I guess the function could also just have
three output parameters.)

[Dan Beam, 2014/11/25 22:49:31]

Deleted.

+  // One or more font families (e.g. "Verdana, sans-serif").
+  std::string font_family;
+
+  // The base font size for webui pages (e.g. "75%").
+  std::string font_size;
+
+  // Text directionality (e.g. "ltr" or "rtl").
+  std::string text_direction;
+};
+
 // Interface that the embedder implements.
 class CONTENT_EXPORT ContentClient {
  public:
   ContentClient();
   virtual ~ContentClient();
 
   ContentBrowserClient* browser() { return browser_; }
   ContentPluginClient* plugin() { return plugin_; }
   ContentRendererClient* renderer() { return renderer_; }
   ContentUtilityClient* utility() { return utility_; }
@@ skipping 30 matching lines @@
 
   // Return the contents of a resource in a StringPiece given the resource id.
   virtual base::StringPiece GetDataResource(
       int resource_id,
       ui::ScaleFactor scale_factor) const;
 
   // Returns the raw bytes of a scale independent data resource.
   virtual base::RefCountedStaticMemory* GetDataResourceBytes(
       int resource_id) const;
 
+  // Returns some shared WebUI text styles. These map to the direction:,
+  // font-family:, and font-size: attributes in CSS.
+  virtual WebUITextStyles GetWebUITextStyles() const;

[davidben, 2014/11/25 22:26:25]

Actually, is this hook even needed? The Chrome implementation just pulls it from
ui/base/webui which content already depends on.

[Dan Beam, 2014/11/25 22:49:31]

Removed to just use ui/base/webui/ directly from content/browser/

+
   // Returns a native image given its id.
   virtual gfx::Image& GetNativeImageNamed(int resource_id) const;
 
   // Called by content::GetProcessTypeNameInEnglish for process types that it
   // doesn't know about because they're from the embedder.
   virtual std::string GetProcessTypeNameInEnglish(int type);
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
   // Allows the embedder to define a new |sandbox_type| by mapping it to the
   // resource ID corresponding to the sandbox profile to use. The legal values
@@ skipping 17 matching lines @@
   ContentPluginClient* plugin_;
   // The embedder API for participating in renderer logic.
   ContentRendererClient* renderer_;
   // The embedder API for participating in utility logic.
   ContentUtilityClient* utility_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_