Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 747903006: [DevTools] Support permessage-deflate in AndroidWebSocket. (Closed)

Created:
6 years ago by dgozman
Modified:
6 years ago
Reviewers:
vkuzkokov, pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@deflate
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support permessage-deflate in AndroidWebSocket. BUG=438230 Committed: https://crrev.com/13fbeece908a65fb7264a3ccc3ce522fb62c276f Cr-Commit-Position: refs/heads/master@{#308428}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -42 lines) Patch
M chrome/browser/devtools/device/android_device_manager.h View 1 4 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/devtools/device/android_device_manager.cc View 1 10 chunks +61 lines, -37 lines 0 comments Download
M chrome/browser/devtools/device/android_web_socket.cc View 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dgozman
Take a look please. Based on https://codereview.chromium.org/769423005/.
6 years ago (2014-12-03 16:38:38 UTC) #2
vkuzkokov
On 2014/12/03 16:38:38, dgozman wrote: > Take a look please. Based on https://codereview.chromium.org/769423005/. lgtm
6 years ago (2014-12-03 18:34:04 UTC) #3
pfeldman
lgtm
6 years ago (2014-12-12 12:13:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747903006/20001
6 years ago (2014-12-15 20:54:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 21:48:39 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 21:49:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13fbeece908a65fb7264a3ccc3ce522fb62c276f
Cr-Commit-Position: refs/heads/master@{#308428}

Powered by Google App Engine
This is Rietveld 408576698