Source/core/rendering/compositing/RenderLayerCompositor.cpp - Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: call updateDescendantDependentFlags() before calling hasVisibleContent() otherwise it crashes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/page/scrolling/ScrollingCoordinator.cpp ('K') | « Source/core/page/scrolling/ScrollingCoordinator.cpp ('k') | Source/web/tests/ScrollingCoordinatorChromiumTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/RenderLayerCompositor.cpp

diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.cpp b/Source/core/rendering/compositing/RenderLayerCompositor.cpp

index 2f51e2187c133b40a6f2b37a06e06a82269c48e9..6b1e3a477dde4ab789ffd9770c515d6d5adfdb5a 100644

--- a/Source/core/rendering/compositing/RenderLayerCompositor.cpp

+++ b/Source/core/rendering/compositing/RenderLayerCompositor.cpp

@@ -529,7 +529,7 @@ void RenderLayerCompositor::frameViewDidScroll()

if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator()) {

if (Settings* settings = m_renderView.document().settings()) {

if (m_renderView.frame()->isLocalRoot() || settings->preferCompositingToLCDTextEnabled())

- scrollingCoordinatorHandlesOffset = scrollingCoordinator->scrollableAreaScrollLayerDidChange(frameView);

+ scrollingCoordinatorHandlesOffset = scrollingCoordinator->scrollableAreaScrollLayerDidChange(frameView, frameView->hasVisibleViewportConstrainedObjects());

}