UMA stats for time settings

Add UMA stats for time settings

BUG=433988
R=stevenjb@chromium.org,asvitkine@chromium.org

Committed: https://crrev.com/108c24de342cf96b5c22a3a6816250f6b46f6ad3
Cr-Commit-Position: refs/heads/master@{#307093}

[stevenjb, 2014-11-21 17:35:52]

lgtm

https://codereview.chromium.org/747883002/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/747883002/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:9358: <action name="Options_Timezone">
nit: Maybe name this TimezoneSelect?

[michaelpg, 2014-11-21 17:44:54]

https://codereview.chromium.org/747883002/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/747883002/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:9358: <action name="Options_Timezone">
On 2014/11/21 17:35:52, stevenjb wrote:
> nit: Maybe name this TimezoneSelect?

I actually checked, and we never use "XYZSelect". Just "XYZ" for dropdowns.

[stevenjb, 2014-11-21 18:20:07]

On 2014/11/21 17:44:54, michaelpg wrote:
>
https://codereview.chromium.org/747883002/diff/1/tools/metrics/actions/action...
> File tools/metrics/actions/actions.xml (right):
> 
>
https://codereview.chromium.org/747883002/diff/1/tools/metrics/actions/action...
> tools/metrics/actions/actions.xml:9358: <action name="Options_Timezone">
> On 2014/11/21 17:35:52, stevenjb wrote:
> > nit: Maybe name this TimezoneSelect?
> 
> I actually checked, and we never use "XYZSelect". Just "XYZ" for dropdowns.

Hmm, well, I can't speak for the other cases, but here the name really implies
that we are tracking the timezone value, not the action of selecting a timezone.
I realize that since it is in "actions" that isn't possible, but I still think
it could be confusing. I don't feel that strongly, but personally think we might
want to set a new precedent.

[michaelpg, 2014-11-21 18:56:46]

On 2014/11/21 18:20:07, stevenjb wrote:
> On 2014/11/21 17:44:54, michaelpg wrote:
> >
>
https://codereview.chromium.org/747883002/diff/1/tools/metrics/actions/action...
> > File tools/metrics/actions/actions.xml (right):
> > 
> >
>
https://codereview.chromium.org/747883002/diff/1/tools/metrics/actions/action...
> > tools/metrics/actions/actions.xml:9358: <action name="Options_Timezone">
> > On 2014/11/21 17:35:52, stevenjb wrote:
> > > nit: Maybe name this TimezoneSelect?
> > 
> > I actually checked, and we never use "XYZSelect". Just "XYZ" for dropdowns.
> 
> Hmm, well, I can't speak for the other cases, but here the name really implies
> that we are tracking the timezone value, not the action of selecting a
timezone.
> I realize that since it is in "actions" that isn't possible, but I still think
> it could be confusing. I don't feel that strongly, but personally think we
might
> want to set a new precedent.

OK, sounds good to me.

[Alexei Svitkine (slow), 2014-11-24 22:46:25]

lgtm

[michaelpg, 2014-12-05 02:54:13]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2014-12-05 02:55:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/747883002/20001

[commit-bot: I haz the power, 2014-12-05 03:02:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 03:02:45]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[michaelpg, 2014-12-05 04:15:52]

On 2014/12/05 03:02:45, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

This is weird.

** Presubmit Warnings **
File chrome/browser/resources/options/browser_options.html line 304:
Options_Use24HourClockCheckbox is missing in tools/metrics/actions/actions.xml.
Please run tools/metrics/actions/extract_actions.py to update.

Options_Use24HourClockCheckbox is set as the metric of an <input
type="checkbox">, so the metrics are Options_Use24HourClockCheckbox_Disable and
Options_Use24HourClockCheckbox_Enable. This is how other checkboxes work.

extract_actions.py says "actions.xml is correctly pretty-printed." so I'll
assume this is some kind of merge conflict and re-check the cq bit.

[michaelpg, 2014-12-05 04:29:33]

On 2014/12/05 04:15:52, michaelpg wrote:
> On 2014/12/05 03:02:45, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux
> >
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> This is weird.
> 
> ** Presubmit Warnings **
> File chrome/browser/resources/options/browser_options.html line 304:
> Options_Use24HourClockCheckbox is missing in
tools/metrics/actions/actions.xml.
> Please run tools/metrics/actions/extract_actions.py to update.
> 
> Options_Use24HourClockCheckbox is set as the metric of an <input
> type="checkbox">, so the metrics are Options_Use24HourClockCheckbox_Disable
and
> Options_Use24HourClockCheckbox_Enable. This is how other checkboxes work.
> 
> extract_actions.py says "actions.xml is correctly pretty-printed." so I'll
> assume this is some kind of merge conflict and re-check the cq bit.

actually, I am getting this error locally in presubmit_support.py, even though
extract_actions.py still says everything is fine.

Even if I remove the lines in actions.xml and let extract_actions.py add them
back (sans useful comments), presubmit_support.py still fails.

Starting to suspect https://codereview.chromium.org/719463003 from 11 hours
ago...

[michaelpg, 2014-12-05 21:22:23]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2014-12-05 21:23:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/747883002/20001

[commit-bot: I haz the power, 2014-12-05 22:09:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-05 22:10:42]

Patchset 2 (id:??) landed as
https://crrev.com/108c24de342cf96b5c22a3a6816250f6b46f6ad3
Cr-Commit-Position: refs/heads/master@{#307093}