Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 747853002: components: Cleanup gn check errors on 'bookmarks' component. (Closed)

Created:
6 years, 1 month ago by tfarina
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, brettw, Dirk Pranke, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

components: Cleanup gn check errors on 'bookmarks' component. This was checked with the following command line: $ out/Debug/gn check out_gn/Debug/ //components/bookmarks/* And cleaned until it reported "Header dependency check OK". BUG=376000, 367595 TEST=see above R=sky@chromium.org Committed: https://crrev.com/82d04114f4b40f1271e10d14d3bc51e1623e7f52 Cr-Commit-Position: refs/heads/master@{#305346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M components/bookmarks/browser/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
6 years, 1 month ago (2014-11-21 03:15:15 UTC) #1
sky
LGTM
6 years, 1 month ago (2014-11-21 16:12:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747853002/1
6 years, 1 month ago (2014-11-22 02:06:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-22 02:46:24 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 02:47:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82d04114f4b40f1271e10d14d3bc51e1623e7f52
Cr-Commit-Position: refs/heads/master@{#305346}

Powered by Google App Engine
This is Rietveld 408576698