IDL compiler: [ActiveDOMObject] interface

IDL compiler: [ActiveDOMObject] interface

First interface extended attribute.

Each of these requires a separate test IDL file,
as do combinations of extended attributes that interact,
due to having one interface per file.

The test interface can be *empty* if the extended attribute 
only affects the overall interface code (e.g., [ActiveDOMObject]),
but needs to have attributes or methods if these are also affected
(e.g., [CheckSecurity]).

I will be primarily activating existing tests by removing the "SKIP" from
run-bindings-tests, and writing new tests if necessary.
Following existing naming, these are generally called
Test<ExtAttr>Interface.idl
...for some value of <ExtAttr>.

This CL also renames an incorrectly named file:
TestActiveDOMObject.idl => TestCheckSecurityInterface.idl
...and adds a new test file:
TestActiveDOMObjectInterface.idl

BUG=239771
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162256

[Nils Barth (inactive), 2013-11-18 10:57:04]

First interface extended attribute!

[haraken, 2013-11-18 11:36:50]

LGTM

https://codereview.chromium.org/74783008/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/74783008/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:342: ActiveDOMObject*
{{v8_class_name}}::toActiveDOMObject(v8::Handle<v8::Object> object)

object => wrapper

[Nils Barth (inactive), 2013-11-19 01:06:50]

https://codereview.chromium.org/74783008/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/74783008/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:342: ActiveDOMObject*
{{v8_class_name}}::toActiveDOMObject(v8::Handle<v8::Object> object)
On 2013/11/18 11:36:50, haraken wrote:
> object => wrapper

Changes Perl (so needs testing), will do in quick followup.

[commit-bot: I haz the power, 2013-11-19 01:09:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/74783008/1

[commit-bot: I haz the power, 2013-11-19 01:09:15]

Failed to apply patch for
Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp
  Copied Source/bindings/tests/results/V8TestActiveDOMObject.cpp ->
Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp
  patching file Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp
  Hunk #15 FAILED at 336.
  1 out of 18 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp.rej

Patch:   NR 
Source/bindings/tests/results/V8TestActiveDOMObject.cpp->Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp
Index: Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp
diff --git a/Source/bindings/tests/results/V8TestActiveDOMObject.cpp
b/Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp
similarity index 64%
copy from Source/bindings/tests/results/V8TestActiveDOMObject.cpp
copy to Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp
index
d55cc85174ab412804d01cecd580d73fc3f55924..db7c6458b29f5dc44352ee35b97e36dc6a41c688
100644
--- a/Source/bindings/tests/results/V8TestActiveDOMObject.cpp
+++ b/Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp
@@ -31,7 +31,7 @@
 // This file has been auto-generated by code_generator_v8.pm. DO NOT MODIFY!
 
 #include "config.h"
-#include "V8TestActiveDOMObject.h"
+#include "V8TestCheckSecurityInterface.h"
 
 #include "RuntimeEnabledFeatures.h"
 #include "V8Node.h"
@@ -50,10 +50,10 @@
 
 namespace WebCore {
 
-static void initializeScriptWrappableForInterface(TestActiveDOMObject* object)
+static void initializeScriptWrappableForInterface(TestCheckSecurityInterface*
object)
 {
     if (ScriptWrappable::wrapperCanBeStoredInObject(object))
-        ScriptWrappable::setTypeInfoInObject(object,
&V8TestActiveDOMObject::wrapperTypeInfo);
+        ScriptWrappable::setTypeInfoInObject(object,
&V8TestCheckSecurityInterface::wrapperTypeInfo);
     else
         ASSERT_NOT_REACHED();
 }
@@ -64,50 +64,50 @@ static void
initializeScriptWrappableForInterface(TestActiveDOMObject* object)
 // the local declaration does not pick up the surrounding namespace. Therefore,
we provide this function
 // in the global namespace.
 // (More info on the MSVC bug here:
http://connect.microsoft.com/VisualStudio/feedback/details/664619/the-namespa...)
-void webCoreInitializeScriptWrappableForInterface(WebCore::TestActiveDOMObject*
object)
+void
webCoreInitializeScriptWrappableForInterface(WebCore::TestCheckSecurityInterface*
object)
 {
     WebCore::initializeScriptWrappableForInterface(object);
 }
 
 namespace WebCore {
-const WrapperTypeInfo V8TestActiveDOMObject::wrapperTypeInfo = {
V8TestActiveDOMObject::GetTemplate, V8TestActiveDOMObject::derefObject, 0, 0, 0,
V8TestActiveDOMObject::installPerContextEnabledMethods, 0,
WrapperTypeObjectPrototype };
+const WrapperTypeInfo V8TestCheckSecurityInterface::wrapperTypeInfo = {
V8TestCheckSecurityInterface::GetTemplate,
V8TestCheckSecurityInterface::derefObject, 0, 0, 0,
V8TestCheckSecurityInterface::installPerContextEnabledMethods, 0,
WrapperTypeObjectPrototype };
 
-namespace TestActiveDOMObjectV8Internal {
+namespace TestCheckSecurityInterfaceV8Internal {
 
 template <typename T> void V8_USE(T) { }
 
 static void excitingAttrAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
-    TestActiveDOMObject* imp = V8TestActiveDOMObject::toNative(info.Holder());
+    TestCheckSecurityInterface* imp =
V8TestCheckSecurityInterface::toNative(info.Holder());
     v8SetReturnValueInt(info, imp->excitingAttr());
 }
 
 static void excitingAttrAttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestActiveDOMObjectV8Internal::excitingAttrAttributeGetter(info);
+    TestCheckSecurityInterfaceV8Internal::excitingAttrAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
 }
 
 bool indexedSecurityCheck(v8::Local<v8::Object> host, uint32_t index,
v8::AccessType type, v8::Local<v8::Value>)
 {
-    TestActiveDOMObject* imp =  V8TestActiveDOMObject::toNative(host);
+    TestCheckSecurityInterface* imp = 
V8TestCheckSecurityInterface::toNative(host);
     return BindingSecurity::shouldAllowAccessToFrame(imp->frame(),
DoNotReportSecurityError);
 }
 
 bool namedSecurityCheck(v8::Local<v8::Object> host, v8::Local<v8::Value> key,
v8::AccessType type, v8::Local<v8::Value>)
 {
-    TestActiveDOMObject* imp =  V8TestActiveDOMObject::toNative(host);
+    TestCheckSecurityInterface* imp = 
V8TestCheckSecurityInterface::toNative(host);
     return BindingSecurity::shouldAllowAccessToFrame(imp->frame(),
DoNotReportSecurityError);
 }
 
 static void excitingFunctionMethod(const v8::FunctionCallbackInfo<v8::Value>&
info)
 {
     if (UNLIKELY(info.Length() < 1)) {
-        throwTypeError(ExceptionMessages::failedToExecute("excitingFunction",
"TestActiveDOMObject", ExceptionMessages::notEnoughArguments(1, info.Length())),
info.GetIsolate());
+        throwTypeError(ExceptionMessages::failedToExecute("excitingFunction",
"TestCheckSecurityInterface", ExceptionMessages::notEnoughArguments(1,
info.Length())), info.GetIsolate());
         return;
     }
-    TestActiveDOMObject* imp = V8TestActiveDOMObject::toNative(info.Holder());
+    TestCheckSecurityInterface* imp =
V8TestCheckSecurityInterface::toNative(info.Holder());
     ExceptionState exceptionState(info.Holder(), info.GetIsolate());
     if (!BindingSecurity::shouldAllowAccessToFrame(imp->frame(),
exceptionState)) {
         exceptionState.throwIfNeeded();
@@ -120,17 +120,17 @@ static void excitingFunctionMethod(const
v8::FunctionCallbackInfo<v8::Value>& in
 static void excitingFunctionMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMMethod");
-    TestActiveDOMObjectV8Internal::excitingFunctionMethod(info);
+    TestCheckSecurityInterfaceV8Internal::excitingFunctionMethod(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
 }
 
 static void postMessageMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (UNLIKELY(info.Length() < 1)) {
-        throwTypeError(ExceptionMessages::failedToExecute("postMessage",
"TestActiveDOMObject", ExceptionMessages::notEnoughArguments(1, info.Length())),
info.GetIsolate());
+        throwTypeError(ExceptionMessages::failedToExecute("postMessage",
"TestCheckSecurityInterface", ExceptionMessages::notEnoughArguments(1,
info.Length())), info.GetIsolate());
         return;
     }
-    TestActiveDOMObject* imp = V8TestActiveDOMObject::toNative(info.Holder());
+    TestCheckSecurityInterface* imp =
V8TestCheckSecurityInterface::toNative(info.Holder());
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, message, info[0]);
     imp->postMessage(message);
 }
@@ -138,7 +138,7 @@ static void postMessageMethod(const
v8::FunctionCallbackInfo<v8::Value>& info)
 static void postMessageMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMMethod");
-    TestActiveDOMObjectV8Internal::postMessageMethod(info);
+    TestCheckSecurityInterfaceV8Internal::postMessageMethod(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
 }
 
@@ -148,19 +148,19 @@ static void postMessageAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>
     static int privateTemplateUniqueKey;
     WrapperWorldType currentWorldType = worldType(info.GetIsolate());
     V8PerIsolateData* data = V8PerIsolateData::from(info.GetIsolate());
-    v8::Handle<v8::FunctionTemplate> privateTemplate =
data->privateTemplate(currentWorldType, &privateTemplateUniqueKey,
TestActiveDOMObjectV8Internal::postMessageMethodCallback, v8Undefined(),
v8::Signature::New(V8PerIsolateData::from(info.GetIsolate())->rawTemplate(&V8TestActiveDOMObject::wrapperTypeInfo,
currentWorldType)), 1);
+    v8::Handle<v8::FunctionTemplate> privateTemplate =
data->privateTemplate(currentWorldType, &privateTemplateUniqueKey,
TestCheckSecurityInterfaceV8Internal::postMessageMethodCallback, v8Undefined(),
v8::Signature::New(V8PerIsolateData::from(info.GetIsolate())->rawTemplate(&V8TestCheckSecurityInterface::wrapperTypeInfo,
currentWorldType)), 1);
 
-    v8::Handle<v8::Object> holder =
info.This()->FindInstanceInPrototypeChain(V8TestActiveDOMObject::GetTemplate(info.GetIsolate(),
currentWorldType));
+    v8::Handle<v8::Object> holder =
info.This()->FindInstanceInPrototypeChain(V8TestCheckSecurityInterface::GetTemplate(info.GetIsolate(),
currentWorldType));
     if (holder.IsEmpty()) {
         // can only reach here by 'object.__proto__.func', and it should passed
         // domain security check already
         v8SetReturnValue(info, privateTemplate->GetFunction());
         return;
     }
-    TestActiveDOMObject* imp = V8TestActiveDOMObject::toNative(holder);
+    TestCheckSecurityInterface* imp =
V8TestCheckSecurityInterface::toNative(holder);
     if (!BindingSecurity::shouldAllowAccessToFrame(imp->frame(),
DoNotReportSecurityError)) {
         static int sharedTemplateUniqueKey;
-        v8::Handle<v8::FunctionTemplate> sharedTemplate =
data->privateTemplate(currentWorldType, &sharedTemplateUniqueKey,
TestActiveDOMObjectV8Internal::postMessageMethodCallback, v8Undefined(),
v8::Signature::New(V8PerIsolateData::from(info.GetIsolate())->rawTemplate(&V8TestActiveDOMObject::wrapperTypeInfo,
currentWorldType)), 1);
+        v8::Handle<v8::FunctionTemplate> sharedTemplate =
data->privateTemplate(currentWorldType, &sharedTemplateUniqueKey,
TestCheckSecurityInterfaceV8Internal::postMessageMethodCallback, v8Undefined(),
v8::Signature::New(V8PerIsolateData::from(info.GetIsolate())->rawTemplate(&V8TestCheckSecurityInterface::wrapperTypeInfo,
currentWorldType)), 1);
         v8…
(message too large)

[commit-bot: I haz the power, 2013-11-19 01:27:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/74783008/80001

[commit-bot: I haz the power, 2013-11-19 01:28:42]

Change committed as 162256

[Nils Barth (inactive), 2013-11-19 02:16:33]

https://codereview.chromium.org/74783008/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/74783008/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:342: ActiveDOMObject*
{{v8_class_name}}::toActiveDOMObject(v8::Handle<v8::Object> object)
On 2013/11/19 01:06:51, Nils Barth wrote:
> On 2013/11/18 11:36:50, haraken wrote:
> > object => wrapper
> 
> Changes Perl (so needs testing), will do in quick followup.

Posted in:
IDL compiler: rename object => wrapper in toActiveDOMObject
https://codereview.chromium.org/75933002/