Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects-visiting.cc

Issue 7477045: Tentative implementation of string slices (hidden under the flag --string-slices). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Some more suggested changes. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 return kVisitSeqTwoByteString; 51 return kVisitSeqTwoByteString;
52 } 52 }
53 53
54 case kConsStringTag: 54 case kConsStringTag:
55 if (IsShortcutCandidate(instance_type)) { 55 if (IsShortcutCandidate(instance_type)) {
56 return kVisitShortcutCandidate; 56 return kVisitShortcutCandidate;
57 } else { 57 } else {
58 return kVisitConsString; 58 return kVisitConsString;
59 } 59 }
60 60
61 case kSlicedStringTag:
62 return kVisitSlicedString;
63
61 case kExternalStringTag: 64 case kExternalStringTag:
62 return GetVisitorIdForSize(kVisitDataObject, 65 return GetVisitorIdForSize(kVisitDataObject,
63 kVisitDataObjectGeneric, 66 kVisitDataObjectGeneric,
64 ExternalString::kSize); 67 ExternalString::kSize);
65 } 68 }
66 UNREACHABLE(); 69 UNREACHABLE();
67 } 70 }
68 71
69 switch (instance_type) { 72 switch (instance_type) {
70 case BYTE_ARRAY_TYPE: 73 case BYTE_ARRAY_TYPE:
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 kVisitStructGeneric, 147 kVisitStructGeneric,
145 instance_size); 148 instance_size);
146 149
147 default: 150 default:
148 UNREACHABLE(); 151 UNREACHABLE();
149 return kVisitorIdCount; 152 return kVisitorIdCount;
150 } 153 }
151 } 154 }
152 155
153 } } // namespace v8::internal 156 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698