Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 747683002: [Android] Clean up for UIResourceLayer use in EffectLayer (Closed)

Created:
6 years, 1 month ago by Changwan Ryu
Modified:
6 years, 1 month ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up for UIResourceLayer use in EffectLayer Following up on https://codereview.chromium.org/664173002/, we no longer need to call SetUIResourceId() when we add UIResourceLayer to another layer. BUG=435376 Committed: https://crrev.com/2d2f447ab6cdc5d22fb6dcb2b8136d9f015247e5 Cr-Commit-Position: refs/heads/master@{#305139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/browser/android/edge_effect.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/android/edge_effect_l.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Changwan Ryu
6 years, 1 month ago (2014-11-21 00:29:44 UTC) #2
jdduke (slow)
Yay, lgtm.
6 years, 1 month ago (2014-11-21 00:30:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747683002/1
6 years, 1 month ago (2014-11-21 00:34:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 01:38:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 01:39:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d2f447ab6cdc5d22fb6dcb2b8136d9f015247e5
Cr-Commit-Position: refs/heads/master@{#305139}

Powered by Google App Engine
This is Rietveld 408576698