Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: gin/modules/file_module_provider.h

Issue 74753002: Introduce gin_shell (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style nits Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/modules/file_module_provider.h
diff --git a/gin/modules/file_module_provider.h b/gin/modules/file_module_provider.h
new file mode 100644
index 0000000000000000000000000000000000000000..8c68828ff2481bd6b3785fdf69b829d1cc7c90b1
--- /dev/null
+++ b/gin/modules/file_module_provider.h
@@ -0,0 +1,31 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GIN_MODULES_FILE_MODULE_PROVIDER_H_
+#define GIN_MODULES_FILE_MODULE_PROVIDER_H_
+
+#include <set>
+#include <string>
+#include "base/files/file_path.h"
jochen (gone - plz use gerrit) 2013/11/18 12:46:05 nit. empty line before this one
abarth-chromium 2013/11/18 15:33:05 Done.
+#include "gin/runner.h"
+
+namespace gin {
+
+class FileModuleProvider {
+ public:
+ explicit FileModuleProvider(const base::FilePath& base);
+ virtual ~FileModuleProvider();
jochen (gone - plz use gerrit) 2013/11/18 12:46:05 why is this virtual? Did you intend to have a Modu
abarth-chromium 2013/11/18 15:33:05 Yeah, I had one in an earlier iteration of the CL
+
+ void AttempToLoadModules(Runner* runner, const std::set<std::string>& ids);
jochen (gone - plz use gerrit) 2013/11/18 12:46:05 should this have some kind of callback that is inv
abarth-chromium 2013/11/18 15:33:06 We could certainly add that, but it wouldn't be us
+
+ private:
+ base::FilePath base_;
+ std::set<std::string> attempted_ids_;
+
+ DISALLOW_COPY_AND_ASSIGN(FileModuleProvider);
+};
+
+} // namespace gin
+
+#endif // GIN_MODULES_FILE_MODULE_PROVIDER_H_

Powered by Google App Engine
This is Rietveld 408576698