Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: gin/modules/file_module_provider.h

Issue 74753002: Introduce gin_shell (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style nits Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef GIN_MODULES_FILE_MODULE_PROVIDER_H_
6 #define GIN_MODULES_FILE_MODULE_PROVIDER_H_
7
8 #include <set>
9 #include <string>
10 #include "base/files/file_path.h"
jochen (gone - plz use gerrit) 2013/11/18 12:46:05 nit. empty line before this one
abarth-chromium 2013/11/18 15:33:05 Done.
11 #include "gin/runner.h"
12
13 namespace gin {
14
15 class FileModuleProvider {
16 public:
17 explicit FileModuleProvider(const base::FilePath& base);
18 virtual ~FileModuleProvider();
jochen (gone - plz use gerrit) 2013/11/18 12:46:05 why is this virtual? Did you intend to have a Modu
abarth-chromium 2013/11/18 15:33:05 Yeah, I had one in an earlier iteration of the CL
19
20 void AttempToLoadModules(Runner* runner, const std::set<std::string>& ids);
jochen (gone - plz use gerrit) 2013/11/18 12:46:05 should this have some kind of callback that is inv
abarth-chromium 2013/11/18 15:33:06 We could certainly add that, but it wouldn't be us
21
22 private:
23 base::FilePath base_;
24 std::set<std::string> attempted_ids_;
25
26 DISALLOW_COPY_AND_ASSIGN(FileModuleProvider);
27 };
28
29 } // namespace gin
30
31 #endif // GIN_MODULES_FILE_MODULE_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698