Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolver.dart

Issue 747503002: Tests for matching constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/incremental_resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/incremental_resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_resolver.dart b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
index fc4e42bb05a47b5085e4d051efbf5a3d380847a8..7e416ba6f1a1c124358d422bb6f294a4a8c2556e 100644
--- a/pkg/analyzer/lib/src/generated/incremental_resolver.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
@@ -144,6 +144,7 @@ class DeclarationMatcher extends RecursiveAstVisitor {
@override
visitConstructorDeclaration(ConstructorDeclaration node) {
+ _hasConstructor = true;
ExecutableElement outerExecutable = _enclosingExecutable;
try {
SimpleIdentifier constructorName = node.name;
@@ -1038,24 +1039,15 @@ class _ElementsGatherer extends GeneralizingElementVisitor {
if (!element.isSynthetic) {
_addElement(element);
}
- // Don't visit children (such as a synthetic setter parameter).
+ // Don't visit children (such as synthetic setter parameters).
}
@override
visitPropertyInducingElement(PropertyInducingElement element) {
- // TODO(scheglov) should we remove synthetic variable initializer?
-// _addElement(element);
-// element.getter.accept(this);
-// element.setter.accept(this);
-// _addElement(element.getter);
-// _addElement(element.setter);
- }
-
- @override
- visitTopLevelVariableElement(TopLevelVariableElement element) {
if (!element.isSynthetic) {
_addElement(element);
}
+ // Don't visit children (such as property accessors).
}
void _addElement(Element element) {
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/incremental_resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698