Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 747443002: Undoing instrumentations for task URLRequestSimpleJob::StartAsync (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
Reviewers:
mmenke
CC:
chromium-reviews, michaeln, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, tony, danakj, Lei Zhang, Finnur, Avi (use Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Undoing instrumentations for task URLRequestSimpleJob::StartAsync After the fix, jankiness disappeared from this task. BUG=422489 TBR=tony@chromium.org, danakj@chromium.org, thestig@chromium.org, finnur@chromium.org, michaeln@chromium.org, avi@chromium.org Committed: https://crrev.com/fcefc83beb698980c4c3418374837b3efc6fb7b1 Cr-Commit-Position: refs/heads/master@{#305037}

Patch Set 1 #

Patch Set 2 : Removing changes that conflict with another CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -78 lines) Patch
M chrome/browser/extensions/chrome_url_request_util.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M content/browser/appcache/view_appcache_internals_job.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M content/browser/histogram_internals_request_job.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/tcmalloc_internals_request_job.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/browser/extension_protocols.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_data_job.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M storage/browser/blob/view_blob_internals_job.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vadimt
mmenke, please provide OWNER's approval for net/ Others: TBR, since changes are just undoing earlier ...
6 years, 1 month ago (2014-11-20 16:09:39 UTC) #2
mmenke
On 2014/11/20 16:09:39, vadimt wrote: > mmenke, please provide OWNER's approval for net/ > > ...
6 years, 1 month ago (2014-11-20 16:29:48 UTC) #3
vadimt
Thanks; but the game is not over, as you can see from https://codereview.chromium.org/746483002/. I, as ...
6 years, 1 month ago (2014-11-20 16:47:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/747443002/20001
6 years, 1 month ago (2014-11-20 16:50:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 18:16:39 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 18:17:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fcefc83beb698980c4c3418374837b3efc6fb7b1
Cr-Commit-Position: refs/heads/master@{#305037}

Powered by Google App Engine
This is Rietveld 408576698